-
Notifications
You must be signed in to change notification settings - Fork 116
Reactivate amortization of plan generation of functions. #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- this works for both temporary and non-temporary functions.
2291afa to
b6fde65
Compare
.../java/com/apple/foundationdb/relational/recordlayer/query/functions/CompiledSqlFunction.java
Outdated
Show resolved
Hide resolved
.../java/com/apple/foundationdb/relational/recordlayer/query/functions/CompiledSqlFunction.java
Outdated
Show resolved
Hide resolved
...n/java/com/apple/foundationdb/relational/recordlayer/metadata/RecordLayerInvokedRoutine.java
Outdated
Show resolved
Hide resolved
10f0ad2 to
85ec6bd
Compare
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. Only Metrics ChangedThese queries experienced only metrics changes without any plan changes. If these metrics have substantially changed, Total: 2 queries Statistical Summary (Only Metrics Changed)
Significant Regressions (Only Metrics Changed)There were 2 outliers detected. Outlier queries have a significant regression in at least one field. Statistically, this represents either an increase of more than two standard deviations above the mean or a large absolute increase (e.g., 100).
|
This restores the memoization of plan generation of both temporary and non-temporary invoked routines.
This fixes #3394.