Remove deprecated KeySpacePath methods related to caching the resolved value, and associated list methods on KeySpace #3702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shortly before ResolvedKeySpacePath was introduced, KeySpacePathImpl would store the resolved tuple and remainder in itself. The methods around this have been deprecated for years. More pressingly, what having this value means is that if you have a KeySpacePath that is generated from KeySpaceDirectorys and call toTuple or toSubspace it will resolve in the context that you provide, but if that KeySpacePath came from resolving a key then toTuple / toSubspace will contain the original directory-layer mappings, which could be problematic if the provided context is not on the same cluster.
MMcM
approved these changes
Oct 30, 2025
ScottDugas
force-pushed
the
remove-old-key-space-from-tuple
branch
from
b830d5f to
ec075d2
Compare
|
@ohadzeliger fixed the javadoc separately, so I dropped b830d5f leaving behind just the original commit: ec075d2 |
ScottDugas
changed the title
ScottDugas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly before ResolvedKeySpacePath was introduced,
KeySpacePathImplwould store the resolved tuple and remainder in itself.The methods around this have been deprecated for years.
More pressingly, what having this value means is that if you have a KeySpacePath that is generated from
KeySpaceDirectorys and call toTuple or toSubspace it will resolve in the context that you provide, but if thatKeySpacePathcame from resolving a key then toTuple / toSubspace will contain the original directory-layer mappings, which could be problematic if the provided context is not on the same cluster.