Reduce test load to reduce flakiness #3712
Conversation
ohadzeliger
added
test failure
| commit(context); | ||
| } | ||
|
|
||
| System.out.println("=== initial ==="); |
There was a problem hiding this comment.
Teamscale has findings, but is not reporting them back to PRs right now...
https://fdb.teamscale.io/activity/merge-requests/foundationdb-fdb-record-layer/FoundationDB%2Ffdb-record-layer%2F3712
It's complaining about these println calls, which can probably just be removed, and it's complaining about the length of this method, which I think went from 75 to 77 lines, which is more than the desired 50.
I think these all qualify as adjacent findings, but if you want to resolve them, it might be nice.
I suspect the println can be removed, and adding a
dataModel.saveRecords(loopCount, recordsPerIteration, contextProps, () -> openContext(contextProps)
would help, but maybe not enough to cross the threshold. I suspect getting it down more would either require changes that don't actually reduce the complexity, or putting more state into the data model (such as the contextProperties)
There was a problem hiding this comment.
Removed some lines. The solution in the documentation in Teamscale for the method length problem is to "extract helper functions" which I think, in this case, is not greatly contributing to code legibility. It's also marked as "pre-existing", so I'd rather leave it as-is.
2 participants
Reduce test load: Save fewer records, use fewer threads and adjust tests to account for the different counts.
Resolves #3711