Avoid updating heartbeat if indexing type had failed to be set #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After setting indexing type the future continues to update indexing heartbeats. The thrown exceptions in this path should be replaced with a completeExceptionally to halt this future. This may fix "runner had been closed" exceptions. resolves FoundationDB#3741
ScottDugas
requested changes
Nov 12, 2025
| .build(); | ||
| } | ||
|
|
||
| private CompletableFuture<Void> failedFutureVoid(Throwable ex) { |
Collaborator
There was a problem hiding this comment.
Perhaps it would be worthwhile to put this in MoreAsyncUtil and make it generic (CompletableFuture<T>).
There's definitely other code doing this. (honestly I was a bit surprised it wasn't supported in CompletableFuture or already existing in MoreAsyncUtil)
| if (isTypeStampBlocked(savedStamp) && !policy.shouldAllowUnblock(savedStamp.getBlockID())) { | ||
| // Indexing is blocked | ||
| throw newPartlyBuiltException(savedStamp, newStamp, index); | ||
| return failedFutureVoid(newPartlyBuiltException(savedStamp, newStamp, index)); |
Collaborator
There was a problem hiding this comment.
I don't think I understand how the change here would change any behavior?
I think it's a bit cleaner, but everywhere that you were throwing, you now return, and anything above shouldn't really know whether it completed exceptionally because that was called or an exception was thrown, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setting indexing type the future continues to update indexing heartbeats. The thrown exceptions in this path should be replaced with a completeExceptionally to halt this future.
This may fix "runner had been closed" exceptions.
resolves #3741