docs(changelog): scope E101S07a entries to OSS daemon work only#216
Open
docs(changelog): scope E101S07a entries to OSS daemon work only#216
Conversation
Strip "+ webhook secret provisioning [endpoint]" from the v2.19.0 and v2.20.0 entries. That half of the original commit subject referred to PUT /api/v1/workspaces/:id/webhook-secrets/:source — a Cloud-side REST endpoint (workers/gaai-cloud/api/src/rest/workspaces.ts) that never syncs to GAAI-framework via sync-framework-to-oss.sh. Per DEC-70 (gaai-oss and gaai-cloud are independent products), the OSS CHANGELOG must describe only what an OSS user can install and use without running gaai-cloud. The OSS-relevant change is the daemon HMAC signing helper + header injection in delivery-daemon.sh. Root cause: upstream commit subject conflated OSS daemon edits with a Cloud REST endpoint into one feat() line, and the auto-sync replays commit subjects verbatim into the CHANGELOG. Discipline patch tracked in gaai-platform (boundary check on cross-product commits). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip
+ webhook secret provisioning [endpoint]from the v2.19.0 and v2.20.0 entries forfeat(E101S07a). That half of the original commit subject referred toPUT /api/v1/workspaces/:id/webhook-secrets/:source— a Cloud-side REST endpoint (workers/gaai-cloud/api/src/rest/workspaces.ts) that never ships to GAAI-framework viasync-framework-to-oss.sh(only.gaai/core/is snapshotted).Per DEC-70 (gaai-oss and gaai-cloud are independent products), the OSS CHANGELOG must describe only what an OSS user can install and use without running gaai-cloud.
Diff
Both lines rewritten to:
This describes exactly what landed in
.gaai/core/scripts/delivery-daemon.sh(compute_webhook_hmac helper + header injection at 4 call sites + env var declaration) and in.gaai/core/scripts/tests/test-webhook-hmac.sh.Root cause
Upstream commit
d3f5c347 feat(E101S07a): daemon HMAC signing + webhook secret provisioning (#466)bundled OSS daemon edits (3 files in.gaai/core/) with a Cloud REST endpoint (2 files inworkers/gaai-cloud/) into one PR/one commit. The auto-sync replays commit subjects verbatim intoCHANGELOG.md, so the Cloud half leaked into OSS release notes.Discipline patch in upstream
gaai-platformrepo (memory rule extended to forbid mixed-scope stories/commits — boundary check on cross-product diffs).Test plan
🤖 Generated with Claude Code