[BrickWallCostEstimate] - Cost and quantity estimate of all BIM objects with IFC Type='Wall'#65
[BrickWallCostEstimate] - Cost and quantity estimate of all BIM objects with IFC Type='Wall'#65QuantumNovice wants to merge 4 commits into
Conversation
galou
left a comment
galou
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Can you please address or comment on my review?
Can you also please change commit names starting with [BrickWallCostEstimate] as stated in the pull-request message?
The png file should be renamed BrickWallCostEstimate.png.
| @@ -0,0 +1,144 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Please put the macro into the Information folder
| @@ -0,0 +1,144 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| __Name__ = 'CostEstimate' | |||
There was a problem hiding this comment.
__Name__ = 'Brick Wall Cost Estimate'
| __Version__ = '0.1' | ||
| __Date__ = '2019-6-24' | ||
| __License__ = 'LGPL-3.0-or-later' | ||
| __Web__ = '' |
| __Status__ = 'Alpha' | ||
| __Requires__ = 'FreeCAD >= v0.17' | ||
| __Communication__ = '' | ||
| __Files__ = '' |
There was a problem hiding this comment.
__Files__ = 'BrickWallCostEstimate.png'
| __Communication__ = '' | ||
| __Files__ = '' | ||
|
|
||
| import FreeCAD, math |
There was a problem hiding this comment.
Please use import FreeCAD as app and use app everywhere instead of FreeCAD.
Also add import FreeCADGui as gui.
Please organize your import (standard lib, then system libs then "project libs"), one per line.
| WallEstimator().pretty_all_wall_estimate() | ||
|
|
||
| # Use this for cost estimation of a particular wall | ||
| #WallEstimator().selected_wall_estimate() |
There was a problem hiding this comment.
Improvement suggestion: make this line available by non-hackers by adding a dialog.
| ''' | ||
| # Make it static | ||
| volume_of_wall = obj.Shape.Volume | ||
| volume_of_brick = 9.375*4.875*3.375*25.4**3 # in mm |
| volume_of_brick = 9.375*4.875*3.375*25.4**3 # in mm | ||
|
|
||
| num_bricks = math.ceil(volume_of_wall/volume_of_brick) | ||
| losses = 5/100 |
There was a problem hiding this comment.
A dialog would render these parameters accessible...
| losses = 5/100 | ||
| brick_cost = (num_bricks + num_bricks*losses)* brick_unit_cost | ||
|
|
||
| actual_vol_brick = 9*4.5*3*25.4**3 |
There was a problem hiding this comment.
Nominal dimension of brick in inches.
|
I edited the original post because the answer to some questions were incorrect. |
QuantumNovice
changed the title
galou
force-pushed
the
master
branch
2 times, most recently
from
f300064 to
579f768
Compare
|
bump |
|
bump @QuantumNovice |
|
CC @yorikvanhavre you may be interested in this |
|
I am sorry I lost access to this computer for quite a while. This will be resolved asap. |
4 participants
** This will later be added to BIM workbench. **
Thank you for creating a pull request to contribute to FreeCAD-macros!
To integrate your macro please make sure the following steps are complete:
[MacroName] - Short description.And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.