Preferred accent option #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artjomsR
force-pushed
the
feat/preferred_accent_option
branch
from
067d936 to
c4a41be
Compare
|
Seems like the scraping is dead. Probably no point in merging this unless you can fix the scraper :( |
|
It seems that forvo cloudflare verification comes and goes (it's working for me now), so this PR isn't related to forvo being broken. I'd say it's still worth to merge this now and address forvo issues again if they come up |
artjomsR
force-pushed
the
feat/preferred_accent_option
branch
from
c4a41be to
6c30286
Compare
artjomsR
force-pushed
the
feat/preferred_accent_option
branch
from
6c30286 to
7f6752e
Compare
artjomsR
force-pushed
the
feat/preferred_accent_option
branch
from
7f6752e to
c3d2ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to have a preferred accent. Forvo pronunciations matching the accent will be sorted at the top, the rest will be displayed afterwards. Both groups will be sorted by vote. If accent is empty / not found, then it'll simply sort by vote as it did before