Fix view count parity for shorts across pages #7788
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
3 tasks
|
The feature request was to display the seen view count for shorts in addition to the normal view count, not replace it. Please implement it properly and also fix the incorrect wording, implementing a new feature is not a fix. |
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #7470
Description
Ensures parity in the view counts for shorts across the search page and watch/history pages. Currently the view count displayed when watching shorts is the engaged views (views meeting minimum time requirement and not replays); this instead uses the total views if available, matching the count shown when seeing the page on search.
Screenshots
Testing
Desktop
Additional context