feat(core): refactor core and publisher to integrate coherently #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurshsmith
force-pushed
the
aj/refactor/integrate-core-in-publisher
branch
2 times, most recently
from
d822cd0 to
98bc19c
Compare
Jurshsmith
changed the title
Jurshsmith
force-pushed
the
aj/refactor/integrate-core-in-publisher
branch
from
ece4c43 to
fd250d4
Compare
Jurshsmith
force-pushed
the
aj/refactor/integrate-core-in-publisher
branch
from
fd250d4 to
7c51a09
Compare
Jurshsmith
requested review from
luizstacio,
pedronauck,
lostman and
0xterminator
as code owners
0xterminator
approved these changes
Aug 15, 2024
This was referenced Aug 15, 2024
pedronauck
pushed a commit
that referenced
this pull request
Aug 16, 2024
* feat: refactor core and publisher to integrate coherently * refactor: centralize data parsing in Streamable * refactor: restrict bincode crate to data-parser crate * refactor: fix previous tests * refactor: include minimal publishing tests * refactor: remove old comments * refactor: resolve conflicts
pedronauck
pushed a commit
that referenced
this pull request
Aug 16, 2024
…124) * feat: refactor core and publisher to integrate coherently * refactor: centralize data parsing in Streamable * refactor: restrict bincode crate to data-parser crate * refactor: fix previous tests * refactor: include minimal publishing tests * refactor: remove old comments * refactor: resolve conflicts
pedronauck
pushed a commit
that referenced
this pull request
Aug 16, 2024
…124) * feat: refactor core and publisher to integrate coherently * refactor: centralize data parsing in Streamable * refactor: restrict bincode crate to data-parser crate * refactor: fix previous tests * refactor: include minimal publishing tests * refactor: remove old comments * refactor: resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces key architectural enhancements and refactors the core to better integrate with fuel-streams-publisher. The changes focus on improving modularity, clarity, and flexibility across the codebase:
Streamable Trait Generalization: The Streamable trait is now NATS-agnostic by adopting more generic function signatures. This decouples our core logic from specific messaging systems, allowing for easier future integrations with other stream processing technologies without significant refactoring.
Improved Documentation and Abstraction: Existing abstractions are now more clearly documented, promoting well-defined separation of concerns. This makes it easier for contributors to understand and extend the architecture while reducing the likelihood of cross-cutting concerns.
Decoupled Stream Types: This PR introduces the Streams crate in both fuel-streams-publisher and fuel-streams. By separating streams that can be published from those that can be consumed, the architecture is more flexible and better aligned with the principle of single responsibility, leading to cleaner, more maintainable code.
Closes: #83
Closes: #97
Closes: #84