fix(repo): Migrating away from using the cursor field for ordering + pagination
#494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
reviewed
Jul 11, 2025
| query_builder: &mut QueryBuilder<Postgres>, | ||
| pagination: &QueryPagination, | ||
| cursor_field: &str, | ||
| join_prefix: Option<&str>, |
There was a problem hiding this comment.
Can we remove the prefix here? I believe some places use it to create pagination over join query. Like predicates endpoint
petertonysmith94
force-pushed
the
ps/chore/migrate-away-from-cursor
branch
from
bf6de28 to
5d396c5
Compare
petertonysmith94
force-pushed
the
ps/chore/migrate-away-from-cursor
branch
from
63ec002 to
fb4d018
Compare
|
@luizstacio do we want to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cursorfield for ordering + paginationUnderstanding of the pagination
block_height 0001 0002 <--- 0003 0004 WHERE (block_height > 0002) --- block_height transaction_index 0001 0 0001 1 <--- 0001 2 0001 3 WHERE (block_height = 0001 AND transaction_index > 1) OR (block_height > 0001) --- block_height transaction_index receipt_index 0001 0 0 0001 0 1 <--- 0001 0 2 0001 1 0 0001 2 0 0001 3 0 WHERE ( (block_height = 0001 AND transaction_index = 0 AND receipt_index > 1) OR (block_height = 0001 AND transaction_index > 0) OR (block_height > 0001) )