feat: update docker builds to publish to ECR #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchristopher
requested review from
digorithm,
hal3e and
MujkicA
as code owners
mchristopher
requested review from
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Voxelot
reviewed
Aug 26, 2024
Voxelot
reviewed
Aug 26, 2024
Voxelot
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing final Docker container to ECR to avoid runtime dependencies on GitHub.
Also updating build pipeline to use multiple native runners to build Docker images on both ARM & AMD-based runners in parallel, in order to cut down on build time.