feat!: contract submission tx management #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el-block-committer into feat/tx-manager-experimental
…el-block-committer into feat/tx-manager-experimental
MujkicA
requested review from
digorithm,
hal3e,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Co-authored-by: hal3e <git@hal3e.io>
hal3e
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the use of contract events to detect a successful block submission to the
FuelChainStatecontract in favour of tracking the confirmations of the actual transaction. This is mainly done to avoid problems with potential L1 reorgs.When run, the
block_committerservice will either create a new submission, update existing submissions or idle until the submission criteria is met.The criteria for submitting a new block is that the last submission was finished (the corresponding tx succeeded or failed) and that the next epoch for posting was reached.