fix: uncontrolled block memory growth fuel-simulator #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajpai244
reviewed
Jun 5, 2025
| // | ||
| /// Background block production – a new block is produced every second. | ||
| async fn produce_blocks(state: Arc<AppState>) { | ||
| const MAX_RETAINED_BLOCKS: usize = 10_000; |
There was a problem hiding this comment.
We should refactor it into some file specific for constants? Or make it configurable via some env var.
NOTE: But, since we plan to have a separate PR to take for this, we can just leave a TODO comment here.
There was a problem hiding this comment.
i think its fine, this is just a simulator for fuel-core :/ doesn't exactly need env vars / more configuration.
what do you think?
Dentosal
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for the
fuel-simulatorfor running integration tests. we ensure here that we don't have uncontrolled growth in memory. the blocks vec now holds a maximum of 10_000 blocks, so the max memory usage of this structure at peak is(10_000 * (128 + 28 + 4)) = 1.6 mb. (with the default block size set to 128 bytes)