fix: eigen kms mod #225
Merged
fix: eigen kms mod #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/holesky-cert-verifier-address
to
feat/eigenda-support
June 5, 2025 13:06
rymnc
force-pushed
the
chore/refactor-eigen-kms
branch
from
37bedce to
cfaeb86
Compare
rymnc
force-pushed
the
chore/refactor-eigen-kms
branch
from
cfaeb86 to
2ef2c6e
Compare
Merged
Dentosal
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the unnecessary casts and cleans up the module. it also has dedicated error handling now
ai generated desc:
Key changes include replacing
anyhowerrors with a customErrortype, improving KMS integration, and adding conditional compilation for test helpers.Error Handling Improvements:
packages/adapters/signers/src/eigen/kms.rs: Replacedanyhowerrors with a customErrorenum to provide more granular and descriptive error handling for KMS operations. This includes errors for missing keys, invalid DER formats, and recovery ID issues.Code Refinements:
packages/adapters/signers/src/eigen.rs: Simplified error handling inSigner::Privateby using.expect()for cases where signing with a private key cannot fail.packages/adapters/signers/src/kms_utils.rs: Updated region handling inconfig_for_testingto useaws_config::Regiondirectly, improving consistency with the AWS SDK.Testability Enhancements:
packages/adapters/signers/src/eth.rs: Added conditional compilation (#[cfg(feature = "test-helpers")]) for test-related helper methods and imports to isolate test-specific functionality. [1] [2] [3]