Feat/eigenda support fix eigen state test #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Jun 6, 2025
| let metrics = client.get(metrics_url).send().await?.text().await?; | ||
| assert!( | ||
| metrics.contains("blocks_processed_total"), | ||
| metrics.contains("height_of_latest_commitment"), |
There was a problem hiding this comment.
i think this refers to the state roots posted to the L1, not the actual blobs that were posted, did i understand this correctly?
There was a problem hiding this comment.
Yes, so from my understanding, it should be the latest batch { height of blocks } posted to L1.
There was a problem hiding this comment.
i think that's an invalid metric to look for then because we're concerned with blobs posted not state root commitments :/
bajpai244
force-pushed
the
feat/eigenda-support-fix-eigen-state-test
branch
from
8fae5ff to
5fe79ab
Compare
|
closing this, and opening without forking so that CI can pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #227 , looks for the correct metric height_of_latest_commitment to make sure the test is sound.