Skip to content

feat: implement support for new ABI error codes #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jun 10, 2025
Merged

feat: implement support for new ABI error codes #3894

merged 33 commits into from
Jun 10, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 27, 2025 •
edited
Loading

Release notes

In this release, we:

  • Implement support for new ABI error codes

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this May 27, 2025
@Torres-ssf Torres-ssf added the feat Issue is a feature label May 27, 2025
@vercel Vercel
Copy link

vercel bot commented May 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 11:44am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 11:44am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 11:44am

petertonysmith94
petertonysmith94 reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks solid to me.

Torres-ssf and others added 2 commits June 10, 2025 08:19
@Torres-ssf
delete empty file
e29d2de
@Torres-ssf @petertonysmith94
code refact
24f10f9 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@Torres-ssf Torres-ssf enabled auto-merge (squash) June 10, 2025 11:40
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.7%(-0.26%) 69.63%(-0.3%) 75.22%(-0.18%) 76.71%(-0.25%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/abi-typegen/src/abi/errors/ErrorCode.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/abi-typegen/src/utils/makeErrorCodes.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/abi-typegen/src/utils/parseErrorCodes.ts 75%
(+75%)		 100%
(+100%)		 50%
(+50%)		 75%
(+75%)
🔴 packages/account/src/providers/provider.ts 73.36%
(-0.13%)		 66.17%
(+0%)		 74.13%
(+0%)		 73.19%
(-0.13%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 82.01%
(-0.59%)		 75%
(+0%)		 95.83%
(+0%)		 82.14%
(-0.59%)
🔴 packages/account/src/providers/utils/extract-tx-error.ts 22.72%
(-10.61%)		 6.06%
(-5.05%)		 44.44%
(-12.7%)		 24.63%
(-10.15%)
🔴 packages/program/src/response.ts 9.09%
(-0.43%)		 0%
(+0%)		 0%
(+0%)		 9.09%
(-0.43%)

@Torres-ssf Torres-ssf merged commit bfb62ad into master Jun 10, 2025
24 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/abi-errors branch June 10, 2025 12:07
@fuel-fuels-ts-bot fuel-fuels-ts-bot bot mentioned this pull request Jun 10, 2025
Merged
@arboleya
Copy link
Contributor

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@nelitow nelitow Awaiting requested review from nelitow nelitow is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ABI Error Types
3 participants
@Torres-ssf @arboleya @petertonysmith94