Import indirect trait impls when handling item use statements.

This updates `TraitMap::filter_by_type_item_import` to scan the trait
map for indirect trait impls with generic types matching any of imported
item types.

This makes sure cases like an impl of a `StorageKey<T>` work, when
importing T from a given scope.

Fixes #7330

Author: tritao

sway-core/src/semantic_analysis/namespace/trait_map.rs

@@ -814,6 +814,62 @@ impl TraitMap {
             self.filter_by_type_inner(engines, all_types, decider2),
             engines,
         );
+
+        // include indirect trait impls for cases like StorageKey<T>
+        for key in self.trait_impls.keys() {
+            for entry in self.trait_impls[key].iter() {
+                let TraitEntry {
+                    key:
+                        TraitKey {
+                            name: trait_name,
+                            type_id: trait_type_id,
+                            trait_decl_span,
+                            impl_type_parameters,
+                            is_impl_interface_surface,
+                        },
+                    value:
+                        TraitValue {
+                            trait_items,
+                            impl_span,
+                        },
+                } = entry.inner.as_ref();
+
+                let decider3 =
+                    |left: TypeId, right: TypeId| unify_checker_for_item_import.check(right, left);
+
+                let matches_generic_params = match *engines.te().get(*trait_type_id) {
+                    TypeInfo::Enum(decl_id) => engines
+                        .de()
+                        .get(&decl_id)
+                        .generic_parameters
+                        .iter()
+                        .any(|gp| gp.unifies(type_id, decider3)),
+                    TypeInfo::Struct(decl_id) => engines
+                        .de()
+                        .get(&decl_id)
+                        .generic_parameters
+                        .iter()
+                        .any(|gp| gp.unifies(type_id, decider3)),
+                    _ => false,
+                };
+
+                if matches_generic_params
+                    || impl_type_parameters.iter().any(|tp| decider(type_id, *tp))
+                {
+                    trait_map.insert_inner(
+                        trait_name.clone(),
+                        impl_span.clone(),
+                        trait_decl_span.clone(),
+                        *trait_type_id,
+                        impl_type_parameters.clone(),
+                        trait_items.clone(),
+                        is_impl_interface_surface.clone(),
+                        engines,
+                    );
+                }
+            }
+        }
+
         trait_map
     }
 

sway-core/src/type_system/ast_elements/type_parameter.rs

@@ -162,6 +162,21 @@ impl TypeParameter {
 
         Ok(())
     }
+
+    pub(crate) fn unifies(
+        &self,
+        type_id: TypeId,
+        decider: impl Fn(TypeId, TypeId) -> bool,
+    ) -> bool {
+        match self {
+            TypeParameter::Type(generic_type_parameter) => {
+                decider(type_id, generic_type_parameter.type_id)
+            }
+            TypeParameter::Const(const_generic_parameter) => {
+                decider(type_id, const_generic_parameter.ty)
+            }
+        }
+    }
 }
 
 impl Named for TypeParameter {

test/src/e2e_vm_tests/test_programs/should_pass/trait_map_use_indirect_impl/Forc.lock

@@ -0,0 +1,8 @@
+[[package]]
+name = "std"
+source = "path+from-root-4F829CC0A9DE5C47"
+
+[[package]]
+name = "trait_map_use_indirect_impl"
+source = "member"
+dependencies = ["std"]

test/src/e2e_vm_tests/test_programs/should_pass/trait_map_use_indirect_impl/Forc.toml

@@ -0,0 +1,8 @@
+[project]
+name = "trait_map_use_indirect_impl"
+authors = ["Fuel Labs <contact@fuel.sh>"]
+entry = "main.sw"
+license = "Apache-2.0"
+
+[dependencies]
+std = { path = "../../../../../../sway-lib-std" }

test/src/e2e_vm_tests/test_programs/should_pass/trait_map_use_indirect_impl/src/foobar.sw

@@ -0,0 +1,9 @@
+library;
+
+pub struct StorageFoobar {}
+
+impl StorageKey<StorageFoobar> {
+    pub fn foobar(self) {
+        log("foobar");
+    }
+}

test/src/e2e_vm_tests/test_programs/should_pass/trait_map_use_indirect_impl/src/main.sw

@@ -0,0 +1,15 @@
+contract;
+
+mod foobar;
+
+use foobar::StorageFoobar;
+
+storage {
+    foo: StorageFoobar = StorageFoobar {},
+}
+
+impl Contract {
+    fn foobar() {
+        storage.foo.foobar();
+    }
+}

test/src/e2e_vm_tests/test_programs/should_pass/trait_map_use_indirect_impl/test.toml

@@ -0,0 +1,2 @@
+category = "compile"
+expected_warnings = 0