Add improved checking for ABI names.

Author: tritao

sway-core/src/abi_generation/fuel_abi.rs

@@ -182,7 +182,10 @@ impl TypeId {
             };
 
             if has_abi_name_attribute {
-                if name.is_empty() || !is_valid_identifier_or_path(name.as_str()) {
+                if name.is_empty()
+                    || !is_valid_identifier_or_path(name.as_str())
+                    || name.starts_with("::")
+                {
                     err = Some(handler.emit_err(CompileError::ABIInvalidName {
                         span: attribute_name_span.clone(),
                         name,

test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/src/main.sw

@@ -28,6 +28,9 @@ struct MyStruct5 {}
 #[abi_name(name = "OtherStruct")]
 struct MyStruct6 {}
 
+#[abi_name(name = "::some_module::in_the_same::package")]
+struct MyStruct7 {}
+
 // OK because enums are on a different namespace
 #[abi_name(name = "SameName")]
 enum MyEnum {
@@ -49,6 +52,7 @@ abi MyAbi {
     fn my_struct4() -> MyStruct4;
     fn my_struct5() -> MyStruct5;
     fn my_struct6() -> MyStruct6;
+    fn my_struct7() -> MyStruct7;
     fn other_enum() -> OtherEnum;
     fn my_enum() -> MyEnum;
     fn my_enum1() -> MyEnum1;
@@ -64,6 +68,7 @@ impl MyAbi for Contract {
   fn my_struct4() -> MyStruct4 { MyStruct4{} }
   fn my_struct5() -> MyStruct5 { MyStruct5{} }
   fn my_struct6() -> MyStruct6 { MyStruct6{} }
+  fn my_struct7() -> MyStruct7 { MyStruct7{} }
   fn other_enum() -> OtherEnum { OtherEnum::A }
   fn my_enum() -> MyEnum { MyEnum::A }
   fn my_enum1() -> MyEnum1 { MyEnum1::A }

test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/stdout.snap

@@ -8,10 +8,10 @@ output:
    Compiling library std (sway-lib-std)
    Compiling contract attributes_invalid_abi_names (test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names)
 error: Duplicated name found for renamed ABI type
-  --> test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/src/main.sw:37:19
+  --> test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/src/main.sw:40:19
    |
 ...
-37 | #[abi_name(name = "OtherEnum")]
+40 | #[abi_name(name = "OtherEnum")]
    |                   ^^^^^^^^^^^
    |
   ::: test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/src/other.sw:7:10
@@ -98,5 +98,15 @@ error: Duplicated name found for renamed ABI type
    |
 ____
 
-  Aborting due to 7 errors.
+error: Invalid name found for renamed ABI type.
+  --> test/src/e2e_vm_tests/test_programs/should_fail/attributes_invalid_abi_names/src/main.sw:31:19
+   |
+...
+31 | #[abi_name(name = "::some_module::in_the_same::package")]
+   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: The name must be a valid Sway identifier.
+____
+
+  Aborting due to 8 errors.
 error: Failed to compile attributes_invalid_abi_names