Apply Clippy's uninlined_format_args lint (#7361)

## Description

This PR improves the readability of `format!`, `write!`, etc. macros by
rolling out the Clippy fixes for the `uninlined_format_args` lint.
`cargo clippy` started showing this lint after locally switching to
Cargo v1.88.0.

Additionally, the PR:
- replaces a few occurrences of
`io::Error::new(std::io::ErrorKind::Other, <msg>)` with
`io::Error::other(<msg>)`.
- replaces a single occurrence of `if params.iter().any(|&p| p ==
"all")` with `if params.contains(&"all")`.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Author: ironcev

forc-pkg/src/manifest/dep_modifier.rs

@@ -287,7 +287,7 @@ impl fmt::Display for Section {
             Section::Deps => "dependencies",
             Section::ContractDeps => "contract-dependencies",
         };
-        write!(f, "{}", section)
+        write!(f, "{section}")
     }
 }
 
@@ -335,12 +335,12 @@ impl Section {
                     Dependency::Simple(ver) => {
                         let mut inline = InlineTable::default();
                         inline.insert("version", Value::from(ver.to_string()));
-                        inline.insert("salt", Value::from(format!("0x{}", salt)));
+                        inline.insert("salt", Value::from(format!("0x{salt}")));
                         Item::Value(toml_edit::Value::InlineTable(inline))
                     }
                     Dependency::Detailed(details) => {
                         let mut inline = generate_table(details);
-                        inline.insert("salt", Value::from(format!("0x{}", salt)));
+                        inline.insert("salt", Value::from(format!("0x{salt}")));
                         Item::Value(toml_edit::Value::InlineTable(inline))
                     }
                 };
@@ -445,11 +445,10 @@ mod tests {
             authors = ["Test"]
             entry = "main.sw"
             license = "MIT"
-            name = "{}"
+            name = "{name}"
             
             [dependencies]
-        "#,
-            name
+        "#
         );
         fs::write(base_path.join("Forc.toml"), forc_toml)?;
 
@@ -500,11 +499,10 @@ mod tests {
                 authors = ["Test"]
                 entry = "main.sw"
                 license = "MIT"
-                name = "{}"
+                name = "{name}"
                 
                 [dependencies]
-            "#,
-                name
+            "#
             );
             fs::write(member_path.join("Forc.toml"), forc_toml)?;
 
@@ -942,7 +940,7 @@ mod tests {
         let base_path = temp_dir.path();
         let package_dir = base_path.join("pkg1");
         let dep = "pkg1";
-        let resp = format!("cannot add `{}` as a dependency to itself", dep);
+        let resp = format!("cannot add `{dep}` as a dependency to itself");
 
         let manifest_file = ManifestFile::from_dir(base_path).unwrap();
         let members = manifest_file.member_manifests().unwrap();
@@ -1062,7 +1060,7 @@ mod tests {
         );
         assert_eq!(
             contract_table.get("salt").unwrap().as_str(),
-            Some(format!("0x{}", hex_salt).as_str())
+            Some(format!("0x{hex_salt}").as_str())
         );
     }
 

forc-pkg/src/manifest/mod.rs

@@ -277,7 +277,7 @@ impl FromStr for HexSalt {
 impl Display for HexSalt {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let salt = self.0;
-        write!(f, "{}", salt)
+        write!(f, "{salt}")
     }
 }
 

forc-pkg/src/pkg.rs

@@ -700,10 +700,7 @@ impl BuildPlan {
         // longer exists at its specified location, etc. We must first remove all invalid nodes
         // before we can determine what we need to fetch.
         let invalid_deps = validate_graph(&graph, manifests)?;
-        let members: HashSet<String> = manifests
-            .iter()
-            .map(|(member_name, _)| member_name.clone())
-            .collect();
+        let members: HashSet<String> = manifests.keys().cloned().collect();
         remove_deps(&mut graph, &members, &invalid_deps);
 
         // We know that the remaining nodes have valid paths, otherwise they would have been
@@ -741,11 +738,11 @@ impl BuildPlan {
             }
             println_action_green(
                 "Creating",
-                &format!("a new `Forc.lock` file. (Cause: {})", cause),
+                &format!("a new `Forc.lock` file. (Cause: {cause})"),
             );
             let member_names = manifests
-                .iter()
-                .map(|(_, manifest)| manifest.project.name.to_string())
+                .values()
+                .map(|manifest| manifest.project.name.to_string())
                 .collect();
             crate::lock::print_diff(&member_names, &lock_diff);
             let string = toml::ser::to_string_pretty(&new_lock)

forc-pkg/src/source/ipfs.rs

@@ -93,8 +93,7 @@ impl source::Fetch for Pinned {
                             println_action_green(
                                 "Fetching",
                                 &format!(
-                                    "from {}. Note: This can take several minutes.",
-                                    ipfs_node_gateway_url
+                                    "from {ipfs_node_gateway_url}. Note: This can take several minutes."
                                 ),
                             );
                             cid.fetch_with_gateway_url(&ipfs_node_gateway_url, &dest)
@@ -274,7 +273,7 @@ mod tests {
 
         // Add files
         for (path, content) in files {
-            let full_path = format!("test-project/{}", path);
+            let full_path = format!("test-project/{path}");
             let header = create_header(&full_path, content.len() as u64);
             ar.append(&header, content.as_bytes()).unwrap();
         }

forc-pkg/src/source/reg/index_file.rs

@@ -354,7 +354,7 @@ mod tests {
 
         // Test round-trip serialization
         let serialized = serde_json::to_string_pretty(&deserialized).unwrap();
-        println!("Re-serialized JSON: {}", serialized);
+        println!("Re-serialized JSON: {serialized}");
 
         // Deserialize again to ensure it's valid
         let re_deserialized: IndexFile = serde_json::from_str(&serialized).unwrap();

forc-pkg/src/source/reg/mod.rs

@@ -469,20 +469,17 @@ async fn fetch(fetch_id: u64, pinned: &Pinned, ipfs_node: &IPFSNode) -> anyhow::
                 IPFSNode::WithUrl(gateway_url) => {
                     println_action_green(
                         "Fetching",
-                        &format!("from {}. Note: This can take several minutes.", gateway_url),
+                        &format!("from {gateway_url}. Note: This can take several minutes."),
                     );
                     cid.fetch_with_gateway_url(gateway_url, &path).await
                 }
             };
 
             // If IPFS fails, try CDN fallback
             if let Err(ipfs_error) = ipfs_result {
-                println_action_green("Warning", &format!("IPFS fetch failed: {}", ipfs_error));
+                println_action_green("Warning", &format!("IPFS fetch failed: {ipfs_error}"));
                 fetch_from_s3(pinned, &path).await.with_context(|| {
-                    format!(
-                        "Both IPFS and CDN fallback failed. IPFS error: {}",
-                        ipfs_error
-                    )
+                    format!("Both IPFS and CDN fallback failed. IPFS error: {ipfs_error}")
                 })?;
             }
 
@@ -600,10 +597,7 @@ where
 
     let contents = index_response.text().await?;
     let index_file: IndexFile = serde_json::from_str(&contents).with_context(|| {
-        format!(
-            "Unable to deserialize a github registry lookup response. Body was: \"{}\"",
-            contents
-        )
+        format!("Unable to deserialize a github registry lookup response. Body was: \"{contents}\"")
     })?;
 
     let res = f(index_file).await?;

forc-plugins/forc-client/build.rs

@@ -33,10 +33,8 @@ fn update_proxy_abi_decl_with_file(source_file_path: &Path, minified_json: &str)
 
     // Prepare the replacement string for the `abigen!` macro
     let escaped_json = minified_json.replace('\\', "\\\\").replace('"', "\\\"");
-    let new_abigen = format!(
-        "abigen!(Contract(name = \"ProxyContract\", abi = \"{}\",));",
-        escaped_json
-    );
+    let new_abigen =
+        format!("abigen!(Contract(name = \"ProxyContract\", abi = \"{escaped_json}\",));");
 
     // Use a regular expression to find and replace the `abigen!` macro
     let re = regex::Regex::new(r#"abigen!\(Contract\(name = "ProxyContract", abi = ".*?",\)\);"#)

forc-plugins/forc-client/src/bin/call.rs

@@ -21,7 +21,7 @@ async fn main() {
         }
     };
     if let Err(err) = forc_client::op::call(operation, command).await {
-        println_error(&format!("{}", err));
+        println_error(&format!("{err}"));
         std::process::exit(1);
     }
 }

forc-plugins/forc-client/src/bin/deploy.rs

@@ -6,7 +6,7 @@ async fn main() {
     init_tracing_subscriber(Default::default());
     let command = forc_client::cmd::Deploy::parse();
     if let Err(err) = forc_client::op::deploy(command).await {
-        println_error(&format!("{}", err));
+        println_error(&format!("{err}"));
         std::process::exit(1);
     }
 }

forc-plugins/forc-client/src/bin/run.rs

@@ -6,7 +6,7 @@ async fn main() {
     init_tracing_subscriber(Default::default());
     let command = forc_client::cmd::Run::parse();
     if let Err(err) = forc_client::op::run(command).await {
-        println_error(&format!("{}", err));
+        println_error(&format!("{err}"));
         std::process::exit(1);
     }
 }