Skip to content

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Jul 29, 2024

Description

This implements DelineatedPathExpression AST resolution.

It is built on top of the framework laid down in #5809.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Jul 29, 2024
@tritao tritao self-assigned this Jul 29, 2024
@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch from 2946cc6 to af53126 Compare August 7, 2024 10:22
@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch 2 times, most recently from 22f479a to 1861270 Compare August 19, 2024 15:22
@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch from 1861270 to 7a1157b Compare October 5, 2024 08:29
Copy link

codspeed-hq bot commented Oct 5, 2024

CodSpeed Performance Report

Merging #6309 will degrade performances by 17.18%

Comparing tritao:symbol-resolve-ctx-delineated (7a1157b) with master (d399580)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master tritao:symbol-resolve-ctx-delineated Change
document_symbol 4.4 ms 5.3 ms -17.18%

@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch from 7a1157b to 5acf1c3 Compare October 8, 2024 13:32
@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch 2 times, most recently from 87c09d3 to f0bbca4 Compare October 24, 2024 17:41
@tritao tritao force-pushed the symbol-resolve-ctx-delineated branch from f0bbca4 to 4b8137c Compare December 15, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant