Skip to content

Conversation

alfiedotwtf
Copy link
Contributor

Separating this commit out from the main commit of #6179...

This PR comes in two commits:

  1. The changes to CI - replace cargo-deps with cargo tree
  2. A test commit that will create a cyclic dependency which will be reverted once it's tested to be working

The origin commit message:

  • cargo-deps is no longer maintained
  • cargo-deps doesn't understand workspaces

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@alfiedotwtf alfiedotwtf self-assigned this Sep 9, 2024
@alfiedotwtf alfiedotwtf requested a review from a team September 9, 2024 07:37
@alfiedotwtf alfiedotwtf added ci code quality forc-pkg Everything related to the `forc-pkg` crate. labels Sep 9, 2024
@alfiedotwtf
Copy link
Contributor Author

Excellent, cargo tree picked up the cyclic dependency. I'll revert that commit now.
Screenshot 2024-09-09 at 18 01 48
Screenshot 2024-09-09 at 18 01 22

Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #6515 will degrade performances by 15.37%

Comparing alfie/cargo-tree (5ee3fff) with master (8232d42)

Summary

❌ 1 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master alfie/cargo-tree Change
format 382.3 ms 451.7 ms -15.37%

@alfiedotwtf alfiedotwtf marked this pull request as ready for review September 9, 2024 08:10
@alfiedotwtf alfiedotwtf requested a review from a team as a code owner September 9, 2024 08:10
@alfiedotwtf alfiedotwtf changed the title Replace cargo deps with build-in cargo tree (#6179) Replace cargo deps with built-in cargo tree (#6179) Sep 9, 2024
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
Copy link
Contributor

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sdankel sdankel requested a review from a team September 10, 2024 18:23
@IGI-111 IGI-111 enabled auto-merge (squash) September 10, 2024 18:37
@IGI-111 IGI-111 merged commit 5699721 into master Sep 10, 2024
36 checks passed
@IGI-111 IGI-111 deleted the alfie/cargo-tree branch September 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci code quality forc-pkg Everything related to the `forc-pkg` crate.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants