Skip to content

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Sep 9, 2024

Description

Closes #6468

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel changed the title fix: log decoding in libaries fix: forc-test log decoding in libraries Sep 9, 2024
@sdankel sdankel self-assigned this Sep 9, 2024
@sdankel sdankel requested a review from a team September 9, 2024 23:38
@sdankel sdankel marked this pull request as ready for review September 9, 2024 23:39
@sdankel sdankel requested a review from a team as a code owner September 9, 2024 23:39
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #6518 will not alter performance

Comparing sophie/library-log-bug (55ef46a) with master (5699721)

Summary

✅ 22 untouched benchmarks

@JoshuaBatty JoshuaBatty added the forc-test Everything related to the `forc-test` lib and `forc test` command. label Sep 9, 2024
@JoshuaBatty
Copy link
Member

Nice one thanks. Would we be able to add the tests reported in the original issue as well so we can confirm this situation is fixed as well?

@sdankel sdankel enabled auto-merge (squash) September 10, 2024 00:47
@sdankel sdankel requested a review from a team September 10, 2024 03:54
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sdankel sdankel merged commit 7d574a9 into master Sep 11, 2024
40 checks passed
@sdankel sdankel deleted the sophie/library-log-bug branch September 11, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forc-test Everything related to the `forc-test` lib and `forc test` command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log decoding fails with log id missing

4 participants