Skip to content

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Sep 16, 2024

Description

Doing an unwrap without checking if the value was none was causing a panic. Fixed by throwing an error so we can also see the previous errors.

Fixes #6330

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Doing an unwrap without checking if the value was none was causing a panic.
Fixed by throwing an error so we can also see the previous errors.

Fixes #6330
@esdrubal esdrubal added bug Something isn't working audit-report Related to the audit report labels Sep 16, 2024
@esdrubal esdrubal self-assigned this Sep 16, 2024
Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #6552 will not alter performance

Comparing esdrubal/panic_in_decl_to_type_info (4b4019b) with master (a073a95)

Summary

✅ 22 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review September 17, 2024 10:46
@esdrubal esdrubal requested a review from a team as a code owner September 17, 2024 10:46
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) September 17, 2024 11:38
@JoshuaBatty JoshuaBatty merged commit 520bfe9 into master Sep 17, 2024
38 checks passed
@JoshuaBatty JoshuaBatty deleted the esdrubal/panic_in_decl_to_type_info branch September 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-report Related to the audit report bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic on unwrapping in decl_to_type_info

4 participants