Skip to content

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Jan 22, 2025

Description

The github-pages CI action has been failing since the forc-migrate PR was merged, because the plugin needs to be installed in that workflow.

It was also missing from forc-binaries which is needed for us to be able to distribute the binary.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review January 22, 2025 22:49
@sdankel sdankel requested a review from a team as a code owner January 22, 2025 22:49
@sdankel sdankel requested a review from a team January 22, 2025 22:50
@JoshuaBatty JoshuaBatty requested review from a team January 22, 2025 22:50
@JoshuaBatty JoshuaBatty merged commit 7443b5c into master Jan 22, 2025
39 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/fix-ci-migrate branch January 22, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants