-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Check for type aliases when implementing traits #6875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tritao
merged 14 commits into
master
from
jjcnn/unalias_type_id_in_trait_map_unification
Mar 6, 2025
Merged
Check for type aliases when implementing traits #6875
tritao
merged 14 commits into
master
from
jjcnn/unalias_type_id_in_trait_map_unification
Mar 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
610d237
to
7e268f7
Compare
CodSpeed Performance ReportMerging #6875 will not alter performanceComparing Summary
|
IGI-111
previously approved these changes
Mar 3, 2025
tritao
reviewed
Mar 3, 2025
tritao
reviewed
Mar 3, 2025
test/src/e2e_vm_tests/test_programs/should_fail/type_alias_unification/src/main.sw
Outdated
Show resolved
Hide resolved
tritao
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be the bad cop, just a few minor whitespace issues
tritao
approved these changes
Mar 5, 2025
JoshuaBatty
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6329 .
During insertion of
impl
s into the trait map we used to forget to check for alias types, which meant that it was possible to have multiple implementations of a trait for the same type, one for the original type and one for the alias.#6626 fixed this bug, but the error message was unhelpful in that it reported the error on the original type without mentioning the alias.
This PR improves the error message, and also improves the error message for aliased types when they contain multiple declarations of the same member.
Checklist
Breaking*
orNew Feature
labels where relevant.