Skip to content

unique constants in the IR #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 20, 2025
Merged

unique constants in the IR #6896

merged 14 commits into from
Feb 20, 2025
+641 −379

Conversation

vaivaswatha
Copy link
Contributor

First step as part of #6351 .

@vaivaswatha vaivaswatha self-assigned this Feb 6, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6896 will not alter performance

Comparing vaivaswatha/ir_consts_1 (427fbc8) with master (988be9b)

Summary

✅ 22 untouched benchmarks

@vaivaswatha vaivaswatha marked this pull request as ready for review February 8, 2025 01:54
@vaivaswatha vaivaswatha requested review from a team as code owners February 8, 2025 01:54
IGI-111
IGI-111 previously approved these changes Feb 11, 2025
View reviewed changes
xunilrj
xunilrj previously approved these changes Feb 13, 2025
View reviewed changes
@vaivaswatha vaivaswatha dismissed stale reviews from xunilrj and IGI-111 via 7679f39 February 13, 2025 15:52
@vaivaswatha vaivaswatha enabled auto-merge (squash) February 14, 2025 01:17
@vaivaswatha vaivaswatha requested review from a team, IGI-111 and xunilrj February 14, 2025 01:18
@vaivaswatha vaivaswatha mentioned this pull request Feb 14, 2025
Merged
IGI-111
IGI-111 previously approved these changes Feb 17, 2025
View reviewed changes
@IGI-111 IGI-111 requested a review from a team February 17, 2025 13:55
@vaivaswatha vaivaswatha requested a review from IGI-111 February 19, 2025 04:21
@IGI-111 IGI-111 requested a review from a team February 19, 2025 14:35
@vaivaswatha vaivaswatha merged commit 69ac39e into master Feb 20, 2025
41 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/ir_consts_1 branch February 20, 2025 01:02
vaivaswatha added a commit that referenced this pull request Mar 10, 2025
@vaivaswatha @IGI-111
Introduce GlobalVar akin to LocalVar and introduce get_global i…
13621ae 
…nstruction similar to `get_local`. (#6928)

2nd Step as part of #6351, in continuation to #6896

---------

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees

@vaivaswatha vaivaswatha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaivaswatha @xunilrj @JoshuaBatty @IGI-111