-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Contract self impl #7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Contract self impl #7275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7275 will not alter performanceComparing Summary
|
tritao
reviewed
Jul 7, 2025
tritao
previously approved these changes
Jul 8, 2025
By the way, realized we probably want to add some docs regarding this new functionality. |
prevents compiler issue: `Identifiers cannot begin with a double underscore, as that naming convention is reserved for compiler intrinsics.`
Co-authored-by: IGI-111 <igi-111@protonmail.com>
027979c
to
e85f29a
Compare
Done. |
IGI-111
approved these changes
Jul 10, 2025
tritao
approved these changes
Jul 11, 2025
8 tasks
ironcev
added a commit
that referenced
this pull request
Sep 6, 2025
## Description This PR removes the `ConvertParseThreeError::SelfImplForContract` and the unreachable code branch that was emiting it. #7275 introduces self impls for contracts and transforms every `impl Contract` into `impl <GeneratedAbiName> for Contract` which makes the `SelfImplForContract` error obsolete and the `match` arm that was emitting it unreachable. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Elaela22soL
pushed a commit
to Elaela22soL/sway
that referenced
this pull request
Sep 26, 2025
…lLabs#7375) ## Description This PR removes the `ConvertParseThreeError::SelfImplForContract` and the unreachable code branch that was emiting it. FuelLabs#7275 introduces self impls for contracts and transforms every `impl Contract` into `impl <GeneratedAbiName> for Contract` which makes the `SelfImplForContract` error obsolete and the `match` arm that was emitting it unreachable. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #7030.
Checklist
Breaking*
orNew Feature
labels where relevant.