Skip to content

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Jul 7, 2025

Description

Continuation of #7030.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested review from a team as code owners July 7, 2025 12:52
@xunilrj xunilrj mentioned this pull request Jul 7, 2025
8 tasks
@xunilrj xunilrj temporarily deployed to fuel-sway-bot July 7, 2025 13:03 — with GitHub Actions Inactive
Copy link

codspeed-hq bot commented Jul 7, 2025

CodSpeed Performance Report

Merging #7275 will not alter performance

Comparing xunilrj/contract-self-impl (20ea625) with master (8d4178f)

Summary

✅ 25 untouched benchmarks

@xunilrj xunilrj temporarily deployed to fuel-sway-bot July 7, 2025 14:10 — with GitHub Actions Inactive
tritao
tritao previously approved these changes Jul 8, 2025
@tritao
Copy link
Contributor

tritao commented Jul 8, 2025

By the way, realized we probably want to add some docs regarding this new functionality.

@xunilrj xunilrj requested review from a team as code owners July 9, 2025 16:09
@xunilrj xunilrj temporarily deployed to fuel-sway-bot July 9, 2025 16:09 — with GitHub Actions Inactive
@xunilrj xunilrj force-pushed the xunilrj/contract-self-impl branch from 027979c to e85f29a Compare July 9, 2025 19:14
@xunilrj xunilrj temporarily deployed to fuel-sway-bot July 9, 2025 19:14 — with GitHub Actions Inactive
@xunilrj xunilrj temporarily deployed to fuel-sway-bot July 9, 2025 20:07 — with GitHub Actions Inactive
@xunilrj
Copy link
Contributor Author

xunilrj commented Jul 9, 2025

By the way, realized we probably want to add some docs regarding this new functionality.

Done.

@xunilrj xunilrj requested a review from tritao July 9, 2025 21:05
@IGI-111 IGI-111 requested a review from a team July 10, 2025 15:53
@tritao tritao enabled auto-merge (squash) July 11, 2025 10:42
@tritao tritao temporarily deployed to fuel-sway-bot July 11, 2025 10:42 — with GitHub Actions Inactive
@tritao tritao merged commit 384f46f into master Jul 11, 2025
45 checks passed
@tritao tritao deleted the xunilrj/contract-self-impl branch July 11, 2025 11:02
ironcev added a commit that referenced this pull request Sep 6, 2025
## Description

This PR removes the `ConvertParseThreeError::SelfImplForContract` and
the unreachable code branch that was emiting it.

#7275 introduces self impls for contracts and transforms every `impl
Contract` into `impl <GeneratedAbiName> for Contract` which makes the
`SelfImplForContract` error obsolete and the `match` arm that was
emitting it unreachable.

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Elaela22soL pushed a commit to Elaela22soL/sway that referenced this pull request Sep 26, 2025
…lLabs#7375)

## Description

This PR removes the `ConvertParseThreeError::SelfImplForContract` and
the unreachable code branch that was emiting it.

FuelLabs#7275 introduces self impls for contracts and transforms every `impl
Contract` into `impl <GeneratedAbiName> for Contract` which makes the
`SelfImplForContract` error obsolete and the `match` arm that was
emitting it unreachable.

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants