Skip to content

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Aug 26, 2025

Description

This PR brings the storage_vec_iter_tests in-language test to the newest compiler version and enables it. The test was originally disabled because of #6899 which has been fixed.

To bring the test to the newest compiler version, this PR:

  • fixes trait coherence violations.
  • adds support for const_generics experimental feature.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Aug 26, 2025

CodSpeed Performance Report

Merging #7356 will not alter performance

Comparing ironcev/enable-storage-vec-iter-tests (fc8cad4) with master (8fa01b8)

Summary

✅ 25 untouched benchmarks

@ironcev ironcev marked this pull request as ready for review August 26, 2025 18:37
@ironcev ironcev requested a review from a team as a code owner August 26, 2025 18:37
@ironcev ironcev enabled auto-merge (squash) August 26, 2025 18:37
@ironcev ironcev requested review from a team and bitzoic August 26, 2025 18:37
@IGI-111 IGI-111 requested a review from a team August 26, 2025 18:42
@ironcev ironcev merged commit 13e4df8 into master Aug 26, 2025
41 checks passed
@ironcev ironcev deleted the ironcev/enable-storage-vec-iter-tests branch August 26, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib: std Standard library testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants