-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Improve method resolution for trait method name bindings #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7364 will not alter performanceComparing Summary
|
7993294
to
9bfc436
Compare
9bfc436
to
f57f75b
Compare
…operator calls. Fixes FuelLabs#7330.
f57f75b
to
8610000
Compare
IGI-111
approved these changes
Sep 8, 2025
xunilrj
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler
General compiler. Should eventually become more specific as the issue is triaged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves method resolution for trait method name bindings, like this following example:
This fix is implemented in Gather trait impls from the argument type module when handling trait operator calls..
A general refactor was also done for associated method resolution functions:
Refactor TypeCheckContext::find_method_for_type.
Refactor resolve_method_name.
Closes #7330.
Checklist
Breaking*
orNew Feature
labels where relevant.