Add expressive diagnostics for Warning::UnusedReturnValue
#7382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds expressive diagnostics for the
UnusedReturnValue
warning that explains how to intentionally ignore a returned value by usinglet _ = ...
.The reason for adding the diagnostics was an observed confusion among novice Sway developers in the particular case of using
__dbg
intrinsic as a statement:It was unclear to developers why this usage generates the warning, and also how to remove it.
Additionally, the PR fixes some
uninlined_format_args
Clippy warnings.Checklist
Breaking*
orNew Feature
labels where relevant.