fix: forc-call variable output default estimation with override #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zees-dev
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
zees-dev
added
bug
zees-dev
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
previously approved these changes
Sep 12, 2025
zees-dev
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
approved these changes
Sep 12, 2025
rymnc
approved these changes
Sep 12, 2025
Elaela22soL
pushed a commit
to Elaela22soL/sway
that referenced
this pull request
Sep 26, 2025
…Labs#7384) ## Description When using `forc-call` with a large `--amount`, the transaction incorrectly sets output count equal to the amount value (e.g., transferring 1000 units creates 1000 outputs). ### Solution - Added `--variable-output` parameter to explicitly control output count - Changed default behavior to estimate minimum outputs via dry-run instead of using using amount value as UTXO outputs - Improved type safety by changing `script_json: serde_json::Value` to `script: fuel_tx::Script` ## Testing - Updated tests to verify correct output counts - Added assertions to check `script.outputs().len()` matches expectations - Tests confirm behavior in both dry-run and live execution modes Addresses: FuelLabs#7383 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: z <zees-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
forc-callwith a large--amount, the transaction incorrectly sets output count equal to the amount value (e.g., transferring 1000 units creates 1000 outputs).Solution
--variable-outputparameter to explicitly control output countscript_json: serde_json::Valuetoscript: fuel_tx::ScriptTesting
script.outputs().len()matches expectationsAddresses: #7383
Checklist
Breaking*orNew Featurelabels where relevant.