Skip to content

fix: forc-call variable output default estimation with override #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 12, 2025
Merged

fix: forc-call variable output default estimation with override #7384

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2f5a6d
added variable-output parameter to forc-call
zees-dev Sep 12, 2025
ca7ffe3
variable output defaults to estimation unless explicitly overriden
zees-dev Sep 12, 2025
040ac85
fix compilation errors
zees-dev Sep 12, 2025
ac261cd
call response script_json -> script; using concrete type
zees-dev Sep 12, 2025
079bfe6
unit tests to validate call response script output
zees-dev Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions forc-plugins/forc-client/src/cmd/call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@ pub struct Command {
#[clap(long, short = 'o', default_value = "default", help_heading = "OUTPUT")]
pub output: OutputFormat,

/// Contract call variable output count
#[clap(long, alias = "variable-output", help_heading = "VARIABLE OUTPUT")]
pub variable_output: Option<usize>,

/// Set verbosity levels; currently only supports max 2 levels
/// - `-v=1`: Print decoded logs
/// - `-v=2`: Additionally print receipts and script json
Expand Down
6 changes: 5 additions & 1 deletion forc-plugins/forc-client/src/op/call/call_function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ pub async fn call_function(
mut output,
external_contracts,
contract_abis,
variable_output,
..
} = cmd;

Expand Down Expand Up @@ -88,7 +89,9 @@ pub async fn call_function(
};

// Setup variable output policy and log decoder
let variable_output_policy = VariableOutputPolicy::Exactly(call_parameters.amount as usize);
let variable_output_policy = variable_output
.map(VariableOutputPolicy::Exactly)
.unwrap_or(VariableOutputPolicy::EstimateMinimum);
let error_codes = abi
.unified
.error_codes
Expand Down Expand Up @@ -493,6 +496,7 @@ pub mod tests {
label: None,
output: cmd::call::OutputFormat::Raw,
list_functions: false,
variable_output: None,
verbosity: 0,
debug: false,
}
Expand Down
3 changes: 3 additions & 0 deletions forc-plugins/forc-mcp/src/forc_call/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ fn build_call_command(
gas,
external_contracts: None,
output: OutputFormat::Json,
variable_output: None,
verbosity,
debug: false,
})
Expand Down Expand Up @@ -582,6 +583,7 @@ fn build_list_command(contract_id: &str, abi: &str) -> anyhow::Result<forc_clien
gas: None,
external_contracts: None,
output: OutputFormat::Default,
variable_output: None,
verbosity: 0,
debug: false,
})
Expand Down Expand Up @@ -641,6 +643,7 @@ fn build_transfer_command(
gas: None,
external_contracts: None,
output: OutputFormat::Json,
variable_output: None,
verbosity,
debug: false,
})
Expand Down
Loading