Skip to content

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Sep 22, 2025

Description

Point cargo-unused-deps-check at nightly-2025-08-15, which ships rustc 1.88 so cargo-udeps and its cargo dependencies install cleanly. This should fix the currently failing job.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner September 22, 2025 06:44
@JoshuaBatty JoshuaBatty self-assigned this Sep 22, 2025
@JoshuaBatty JoshuaBatty added the ci label Sep 22, 2025
@JoshuaBatty JoshuaBatty requested review from a team September 22, 2025 06:57
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) September 22, 2025 06:57
@JoshuaBatty JoshuaBatty merged commit 79f7c60 into master Sep 22, 2025
43 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/rust_ci branch September 22, 2025 11:03
Elaela22soL pushed a commit to Elaela22soL/sway that referenced this pull request Sep 26, 2025
## Description
Point `cargo-unused-deps-check` at `nightly-2025-08-15`, which ships
rustc 1.88 so `cargo-udeps` and its cargo dependencies install cleanly.
This should fix the currently
[failing](https://github.com/FuelLabs/sway/actions/runs/17906778883/job/50909289626?pr=7399)
job.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants