Skip to content

Conversation

@gamerbross
Copy link
Contributor

Linked Issues

Couldn't find any.

Description

Vocals waveform didn't stretch/compress when the song tempo/bpm changes midway, making them impossible to use.

Screenshots/Videos

bug.mp4

Before, audio waveforms being shorter than they should, turning almost useless

fix.mp4

After, audio waveforms getting stretched to match the current tempo

@github-actions github-actions bot added size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. labels Jan 28, 2026
@Hundrec Hundrec changed the title [BUGFIX] Chart Editor Waveform Tempo Change Desync [BUGFIX] Fix Chart Editor Waveforms desyncing on BPM change Jan 28, 2026
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. status: pending triage Awaiting review. labels Jan 28, 2026
@Hundrec Hundrec self-requested a review January 28, 2026 10:52
@Hundrec Hundrec added the size: tiny A tiny pull request with 4 or fewer changes. label Jan 28, 2026
@Hundrec Hundrec changed the base branch from dummy/develop-v0.8.1 to develop January 28, 2026 10:55
@Hundrec
Copy link
Member

Hundrec commented Jan 29, 2026

This is an awesome fix, and a one-line banger no less!

I just wonder if there's also a way to prevent the slight shifting around of the waveforms with some more changes?

Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out with Monster and could see the waveforms squash and stretch a bit when there were 2 or more time changes near each other. (scrolling through Section 57)

This is definitely an improvement, but I'd like to know whether there's a more precise formula that could make the waveforms a more similar width across many BPMs?

If not, that's fine! I like this change a lot.

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Jan 31, 2026
@gamerbross
Copy link
Contributor Author

i think adding something like that would require a way to render the waveform with different widths, which i have no idea how to, i just messed with the existing things and got this
image
(really dumb image example)

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 1, 2026
@Hundrec
Copy link
Member

Hundrec commented Feb 1, 2026

Thanks for the response!

I'll get this change in since it's a huge improvement anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

2 participants