-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[BUGFIX] Fix Chart Editor Waveforms desyncing on BPM change #6833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[BUGFIX] Fix Chart Editor Waveforms desyncing on BPM change #6833
Conversation
|
This is an awesome fix, and a one-line banger no less! I just wonder if there's also a way to prevent the slight shifting around of the waveforms with some more changes? |
Hundrec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out with Monster and could see the waveforms squash and stretch a bit when there were 2 or more time changes near each other. (scrolling through Section 57)
This is definitely an improvement, but I'd like to know whether there's a more precise formula that could make the waveforms a more similar width across many BPMs?
If not, that's fine! I like this change a lot.
|
Thanks for the response! I'll get this change in since it's a huge improvement anyway :) |

Linked Issues
Couldn't find any.
Description
Vocals waveform didn't stretch/compress when the song tempo/bpm changes midway, making them impossible to use.
Screenshots/Videos
bug.mp4
Before, audio waveforms being shorter than they should, turning almost useless
fix.mp4
After, audio waveforms getting stretched to match the current tempo