Use CSS files for HaxeUI styling instead of style.xml#7136
Closed
T5mpler wants to merge 96 commits intoFunkinCrew:mainfrom
Closed
Use CSS files for HaxeUI styling instead of style.xml#7136T5mpler wants to merge 96 commits intoFunkinCrew:mainfrom
T5mpler wants to merge 96 commits intoFunkinCrew:mainfrom
Conversation
…mera zoom (different camera!) was above 1.35x.
Reducing to 50% wasn't noticeable enough, but 25% should be a clean reduction.
…rsion or dependency issues.
…red correctly relative to the current framerate.
Any preview values over 15,000 get turned into 0 (start) and 0.2 (end).
Co-Authored-By: Kade <26305836+Kade-github@users.noreply.github.com>
…red Notes debug key
…notes, it's length as well Values can be shown and set in milliseconds or steptime
…0.x versions for new fields with no breaking changes.
Co-Authored-By: Hyper_ <40342021+NotHyper-474@users.noreply.github.com>
…ate in Chart Editor. Co-authored-by: Kolo <67389779+koloindacrib@users.noreply.github.com>
github-actions
bot
added
status: pending triage
Hundrec
added
status: rejected
|
This pull request is a duplicate. Please direct all discussion to the original pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Review this pr instead! Accidentally used the main branch while creating the PR, my apologies)
(Requires this pr to be merged)
This PR re-factors how styling for HaxeUI works by using the built-in HaxeUI css style system using module.xml
Right now the game uses an xml file with an empty box component that has styling to handling all of its styling. While this works, this workaround can cause a lot of issues relating to both z-index and more issues I've personally noticed.
This system HaxeUI uses is a lot more controllable, allowing even for being able to make custom themes.
Lmk if there's an accidental issue this PR has.