-
Notifications
You must be signed in to change notification settings - Fork 34
Description
This package can parse Markdown in hover/completion/signature:
codemirror-languageserver/src/index.ts
Lines 612 to 614 in d8c88a4
| if (contents.kind === "markdown") { | |
| value = marked.parse(value); | |
| } |
Yet, it requests plaintext over markdown in all the cases:
codemirror-languageserver/src/index.ts
Line 143 in d8c88a4
| documentationFormat: ["plaintext", "markdown"], |
codemirror-languageserver/src/index.ts
Line 152 in d8c88a4
| documentationFormat: ["plaintext", "markdown"], |
codemirror-languageserver/src/index.ts
Line 129 in d8c88a4
| contentFormat: ["plaintext", "markdown"], |
which leads to sub-optimal user experience when used with servers complying with LSP specification which says:
The order describes the preferred format of the client
for each of these, e.g. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionClientCapabilities
This is because servers will correctly return plaintext response in these cases. Moreover, plain text is not being correctly escaped resulting in jumbled up text