Memory management improvements #49
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to #50
Please see #50 instead
Main Changes
T** m_rawPtrToMatrices
, which is a raw pointer to the matrices of the tensor (to replacepointersToMatrices
)TODOs
addAB
: usegemm
whennMats=1
m_d_ptrMatrix = nullptr
when slicing withaxis=0
oraxis=1
CholeskyBatchFactoriser
: get rid ofpointersToMatrices
CholeskyBatchFactoriser
: throw error ifnMats=1
addAB
)Associated Issues