Skip to content

Better memory management #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 7, 2024
Merged

Better memory management #50

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aa1317b
Create pointer-to-matrices memory (m_d_ptrMatrices)
alphaville Nov 7, 2024
2ac61cf
Initialise m_d_ptrMatrices
alphaville Nov 7, 2024
3338852
Use initialisePointersToMatricesData to initialise m_d_ptrMatrices
alphaville Nov 7, 2024
36bf6ed
update addAB to use preallocated memory
alphaville Nov 7, 2024
4e5da4d
mirror implementation for DTensor<float>::addAB
alphaville Nov 7, 2024
296efd4
Get rid of pointersToMatrices() in LS
alphaville Nov 7, 2024
02564d5
New method DTensor<T>::ptrMatrices() exposes m_d_ptrMatrices
alphaville Nov 7, 2024
f2e86c7
Completely got rid of pointersToMatrices()
alphaville Nov 7, 2024
424a251
No memory allocation for m_d_ptrMatrices unless nMats > 1
alphaville Nov 7, 2024
b2857cd
ptrMatrices now declared as a const method
alphaville Nov 7, 2024
7c32dae
Update DTensor<T>::reshape
alphaville Nov 7, 2024
225ba0d
Better memory management when reshaping
alphaville Nov 7, 2024
d4b5472
Safe memory allocation in reshape and unit test
alphaville Nov 7, 2024
5b3a677
Test reshape more thoroughly
alphaville Nov 7, 2024
75576ac
Further unit tests for reshape and docs
alphaville Nov 7, 2024
4198ecf
Better memory management in DTensor<T>::allocateOnDevice
alphaville Nov 7, 2024
2c326fc
DTensor<T>::allocateOnDevice: memento mori
alphaville Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


<!-- ---------------------
v1.3.1
--------------------- -->
## v1.3.1 - 8-11-2024

### Fixed

- Memory management improvements: we got rid of `pointerToMatrices`, which would unnecessarily allocate memory and `addAB` does not allocate any new memory internally.

<!-- ---------------------
v1.3.0
--------------------- -->
Expand Down
Loading