hotfix / include ptrMatrices in matrix-axis slices #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruairimoran
changed the title
When slicing, m_d_ptrMatrices should be nullptr unless nMats>1
alphaville
reviewed
Nov 8, 2024
| @@ -659,10 +661,6 @@ DTensor<T>::DTensor(const DTensor<T> &other, size_t axis, size_t from, size_t to | |||
| m_d_data = other.m_d_data + offset; | |||
| m_doDestroyData = false; | |||
| m_doDestroyPtrMatrices = false; | |||
| if (axis != 2) { | |||
There was a problem hiding this comment.
I removed this because I put m_d_ptrMatrices = nullptr; at the beginning.
alphaville
reviewed
Nov 8, 2024
| if (axis == 2) { | ||
| offset = other.m_numRows * other.m_numCols * from; | ||
| m_numRows = other.m_numRows; | ||
| m_numCols = other.m_numCols; | ||
| m_numMats = len; | ||
| m_d_ptrMatrices = other.m_d_ptrMatrices + from; |
There was a problem hiding this comment.
This line should be here (inside if (axis == 2))
Get rid of warning in DTensor<T>::createRandomTensor ci/script: use pushd/popd instead of cd update CHANGELOG
alphaville
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
@ruairimoran I made a couple of changes - we can merge if you're happy with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure ptrMatrices is included when slicing on matrix axis