Skip to content

Conversation

ckissane
Copy link

:)

@NoMod-Programming
Copy link
Collaborator

The new custom blocks look great, and the variable colors/set x and y blocks perform very well! A few minor tweaks are needed in the UI, though, so maybe you can create a new pull request with just the new blocks right now, that way we can import them, and have a seperate PR for the UI?

Honestly, I'm loving the new UI, but it feels a bit "hacked" together at this moment. For example, the tabs, at the first glance, look kind of thrown on hastily, and gray-ish colors in the ScriptsPane and other parts of the UI stand out too much. Also, a faint, 1px blue line appears between the stage and the library. The buttons in the ScriptsPane are in need of a faint outline, too, to give the user a general area to click on, even if it's just when it's hovered over (like Google does). Other than the couple of minor tweaks needed to make this UI fit in, I think this is almost ready to go!

@GRA0007, any thoughts on this?

@NoMod-Programming
Copy link
Collaborator

NoMod-Programming commented Sep 30, 2016

Also, the diff says that every line of code was changed. A github issue?
EDIT: It's because of line endings.
EDIT 2: Nope. It was file permissions

@ckissane
Copy link
Author

ckissane commented Oct 1, 2016

Thats likely a github issue. Oh and I will make some more changes to make
it fit in :).

On Fri, Sep 30, 2016 at 10:50 AM, Edward P. notifications@github.com
wrote:

Also, the diff says that every line of code was changed. A github issue?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJKYesO4-lxNBwd-Jwbwps7ppcxrxLPfks5qvUv8gaJpZM4KDcad
.

@ckissane
Copy link
Author

ckissane commented Oct 1, 2016

I made some already and can update my github if you want.

On Fri, Sep 30, 2016 at 10:44 PM, C L K Kissane coler706@gmail.com wrote:

Thats likely a github issue. Oh and I will make some more changes to make
it fit in :).

On Fri, Sep 30, 2016 at 10:50 AM, Edward P. notifications@github.com
wrote:

Also, the diff says that every line of code was changed. A github issue?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJKYesO4-lxNBwd-Jwbwps7ppcxrxLPfks5qvUv8gaJpZM4KDcad
.

@NoMod-Programming NoMod-Programming mentioned this pull request Apr 17, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants