Skip to content

Migration from Gtk3 to Gtk4 and libadwaita 1.7#2006

Open
Scroker wants to merge 168 commits into
GSConnect:mainfrom
Scroker:gtk4-port
Open

Migration from Gtk3 to Gtk4 and libadwaita 1.7#2006
Scroker wants to merge 168 commits into
GSConnect:mainfrom
Scroker:gtk4-port

Conversation

@Scroker
Copy link
Copy Markdown

@Scroker Scroker commented Apr 28, 2025

This pull request collects the changes I made in order to move the UI of the application from gtk3 to gtk4 and libadwaita 1.7. The version of gnome that is compatible to date is 48.
In general I tried to reuse as much code as possible but obviously the js and xml files related to the UI component are deeply changed. On the daemon instead I intervened almost exclusively to make it compatible with Gtk4.
Finally I reorganized the icon part of the gresource to natively get an Icon Theme.

ferdnyc and others added 30 commits July 31, 2023 20:07
@github-actions
Copy link
Copy Markdown

All conflicts have been resolved, thanks!

@Scroker Scroker force-pushed the gtk4-port branch 2 times, most recently from d17c7eb to 5e833cd Compare December 27, 2025 23:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2026

This pull request has conflicts, please resolve those so that the changes can be evaluated.

@github-actions github-actions Bot added the conflicts Pull requests with merge conflicts that need to be resolved label Feb 1, 2026
@olumolu
Copy link
Copy Markdown

olumolu commented Mar 4, 2026

what is the status of this

@LorierMatthieu
Copy link
Copy Markdown

what is the status of this

The port to Gtk4 is completely functional. I personally use it in everyday life. But it hasn’t been merged yet, and I don’t know when or if it will be. If it can help you, I made this little script to build and install the Gtk4 port:


cd gnome-shell-extension-gsconnect/

meson setup _build . --reconfigure
ninja -C _build install-zip```

Run it after you clone GSConnect.

@olumolu
Copy link
Copy Markdown

olumolu commented Mar 9, 2026

it is working why not just merge it

@GuyDebord
Copy link
Copy Markdown

Yeah the development regarding the GTK4 port has been really disappointing

@obaidabit
Copy link
Copy Markdown

Hope this get merge soon we've been waiting for long 😢

@github-actions github-actions Bot removed the conflicts Pull requests with merge conflicts that need to be resolved label Mar 15, 2026
@github-actions
Copy link
Copy Markdown

All conflicts have been resolved, thanks!

@Scroker
Copy link
Copy Markdown
Author

Scroker commented Mar 15, 2026

For the first time, the code now passes the entire test suite. The only change required was updating the SMS test, as the handleDigest function has been replaced by handleMessages. I also initially encountered issues with the Clipboard test, but after rerunning it today the problem no longer occurs.

IMPORTANT
I understand that this pull request touches a significant portion of the codebase, and that reviewing such changes requires careful attention to ensure that no regressions have been introduced. I completely understand if maintainers prefer to take the time needed to review it thoroughly before merging.

In the meantime, for anyone interested in trying out these changes, the code can already be downloaded and installed by following the instructions in CONTRIBUTING.md. Any feedback, testing results, or reports of issues would be greatly appreciated and will help ensure the stability of the changes.

@JaredTweed
Copy link
Copy Markdown

@ferdnyc Is there any reason why this isn't yet merged? I really look forward to gtk4 for this.

@olumolu
Copy link
Copy Markdown

olumolu commented Apr 24, 2026

why not merge it @Scroker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants