Clean the code as fuck is possible #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+11
to
+42
| name: 🛠️ TypeScript and ESLint on Main | ||
| runs-on: ubuntu-latest | ||
| if: github.ref == 'refs/heads/main' | ||
| steps: | ||
| - name: 📥 Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: ⚙️ Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 20 | ||
|
|
||
| - name: 💾 Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: 🛠️ Commit and Push Fixes ESLint (Main) | ||
| run: | | ||
| git config --global user.name "github-actions[bot]" | ||
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
| npx eslint . --fix | ||
| if git diff --quiet; then | ||
| echo "No changes to commit." | ||
| else | ||
| git add . | ||
| git commit -m "🔧 Auto-fix ESLint issues" | ||
| git push | ||
| fi | ||
| - name: 🔍 Run TypeScript and ESLint checks | ||
| run: npm run lint | ||
|
|
||
| lint-development: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Comment on lines
+43
to
+59
| name: 🛠️ TypeScript and ESLint on Pull Request | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status | ||
| if: github.ref != 'refs/heads/main' | ||
| steps: | ||
| - name: Checkout code | ||
| - name: 📥 Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Pnpm setup | ||
| uses: pnpm/action-setup@v2 | ||
| - name: ⚙️ Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| version: latest | ||
| node-version: 20 | ||
|
|
||
| - name: Environnement setup | ||
| run: pnpm install | ||
| - name: 💾 Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Typescript and Eslint scanning | ||
| run: pnpm lint | ||
| - name: 🔍 Run TypeScript and ESLint checks | ||
| run: npm run lint |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| preserveNewlines: true, | ||
| whitespaceCharacters: " ", | ||
| }); | ||
| const formatted = converted.replace("\n", " ").replace(/Bonjour,|Bonjour à tous|Bonjour !|Bonsoir|Bonjour|Bonjour à tous, |Bonjour , |Bonsoir, /g, "").replace(/\n/g, ""); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the problem, we need to ensure that all newline characters in the converted string are replaced with spaces. This can be achieved by using a regular expression with the global flag (g) in the replace method. Specifically, we should replace "\n" with /\n/g in the replace call on line 8.
Suggested changeset
1
src/utils/format/format_pronote_news.ts
| @@ -7,3 +7,3 @@ | ||
| }); | ||
| const formatted = converted.replace("\n", " ").replace(/Bonjour,|Bonjour à tous|Bonjour !|Bonsoir|Bonjour|Bonjour à tous, |Bonjour , |Bonsoir, /g, "").replace(/\n/g, ""); | ||
| const formatted = converted.replace(/\n/g, " ").replace(/Bonjour,|Bonjour à tous|Bonjour !|Bonsoir|Bonjour|Bonjour à tous, |Bonjour , |Bonsoir, /g, "").replace(/\n/g, ""); | ||
| const trimmed = formatted.trim(); |
Copilot is powered by AI and may make mistakes. Always verify output.
… de produit dans le projet iOS
…raser l'appli original
… jour l'affichage des devoirs
…oirs (évite un plantage btw)
… meilleur lisibilité (PapillonApp#895)
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
Co-authored-by: 𝕂𝕪𝕝𝕚𝕒𝕟 <164187100+Kgeek33@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Nouvelle Pull Request
Proposez vos modifications pour améliorer Papillon
Informations importantes
Merci de vous référer à la documentation sur la contribution si vous avez des questions à propos des pull requests (https://gitbook.getpapillon.xyz/organisation/outils-internes/github)
Checklist d'avant pull request
Veuillez cocher toutes les cases applicables en remplaçant [ ] par [x].
TODO(aka des annotations pour du code manquant) dans vos modificationsChangelogs proposés
Décrivez les modifications que vous avez effectuées.
Informations supplémentaires
Ajoutez ici toute information supplémentaire si nécessaire.