feat: add disable_corefiles context option #2638
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new context option that automatically disables core file generation when enabled. This sets RLIMIT_CORE to (0, -1) to prevent core dump creation, which is particularly useful for brute-force scenarios and repeated segfault crashes where core files consume excessive disk space. - Add disable_corefiles context variable with boolean type. - Add @_validator decorator for disable_corefiles context variable - Default value is False to maintain existing behavior. Fixes Gallopsled#2566
|
Cool, thank you! Can you add a test to the Corefile class demonstrating that there's no Corefile created when setting that option please? We use doctest to run the code in our documentation as tests. Check out corefile.py around line 490 on how it's done. |
RoYalGamr
force-pushed
the
dev
branch
3 times, most recently
from
6075500 to
1ab053d
Compare
|
Could you add a comment about |
Added doctest for `disable_corefiles` in corefile.py Added doc for `disable_corefiles` in process.py When `context.corefiles` is enabled: For crashed process, `io.corefile` will return None. For running process, gdb still dumps the corefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new context option that automatically disables core file generation when enabled. This sets RLIMIT_CORE to (0, -1) to prevent core dump creation, which is particularly useful for brute-force scenarios and repeated segfault crashes where core files consume excessive disk space.
Fixes #2566