-
Notifications
You must be signed in to change notification settings - Fork 128
Paginate category, tag, and author pages #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7d399a5
Not using pathPrefix inside Pagination component
dajocarter 1604034
Use singular prefix in URL
dajocarter 61bd57a
Paginate category pages
dajocarter 684227c
Paginate tag pages
dajocarter 28ec73a
Paginate author pages
dajocarter 8cadbd9
Add missing field in author query
dajocarter 82218b3
Add fallback for post not having a category or tag
dajocarter cb6d3e4
Fix copy/paste typo
dajocarter 741ecc8
[WIP] Add linked numbers to pagination
dajocarter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve been thinking a bit about this one. We have a pagination helper in the awesome pagination plugin. The trick is, we also support defining a function to calculate what the paginated paths should be. In that case, there’s no way to calculate the page number links without that function.
I’m thinking maybe we add some logic that allows for that function to be passed to the pagination component, with the same default used in both the
paginate()
function and the component. It’s an interesting one. Will give it a little more thought...