Skip to content

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Jun 16, 2025

@seisman seisman added the documentation Improvements or additions to documentation label Jun 16, 2025
@seisman
Copy link
Member

seisman commented Jun 16, 2025

Looks good. Could you please also update other links?

@michaelgrund
Copy link
Member Author

Looks good. Could you please also update other links?

Done! Just wanted to check if the syntax is working as expected before adding all links. If I remember correctly, unfortunately there's no recording from @yvonnefroehlich's recent AGU talk, isn't it?

@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Jun 16, 2025
@michaelgrund michaelgrund added this to the 0.16.0 milestone Jun 16, 2025
@yvonnefroehlich
Copy link
Member

Looks good. Could you please also update other links?

[...] If I remember correctly, unfortunately there's no recording from @yvonnefroehlich's recent AGU talk, isn't it?

Unfortunaetly no 🙁. The AGU talks were available on the meeting plattform only for registered meeting attendees (and AGU members) to view through 7 March 2025.

@seisman
Copy link
Member

seisman commented Jun 16, 2025

Also update the link at https://github.com/GenericMappingTools/pygmt/blob/main/README.md#why-pygmt?

@michaelgrund michaelgrund changed the title Add youtube links in overview page Add youtube links landing and overview pages Jun 16, 2025
@michaelgrund michaelgrund changed the title Add youtube links landing and overview pages Add youtube links on landing and overview pages Jun 16, 2025
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Jun 16, 2025
michaelgrund and others added 2 commits June 17, 2025 08:17
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman
Copy link
Member

seisman commented Jun 17, 2025

@yvonnefroehlich What do you think about changes in this PR?

@michaelgrund
Copy link
Member Author

I personally have no strong opinion on showing also the URL to the YT videos as text. However, for me it is somehow clear when clicking on the video images that I get redirected to YT and otherwise I just have get the image in larger dimension with the possibility seeing the content with more details, especially the posters.

[external PyGMT examples](https://www.pygmt.org/latest/external_resources.html)!

![Quick Introduction to PyGMT YouTube Video](https://raw.githubusercontent.com/GenericMappingTools/pygmt/refs/heads/main/doc/_static/scipy2022-youtube-thumbnail.jpg)
[![Quick Introduction to PyGMT YouTube Video](https://raw.githubusercontent.com/GenericMappingTools/pygmt/refs/heads/main/doc/_static/scipy2022-youtube-thumbnail.jpg)](https://www.youtube.com/watch?v=4iPnITXrxVU)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if the README on PyPI still looks nice with this change merged. I remember that there was an issue sometime ago and the image was not displayed correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect no issues since it's only a link embedded within another link.

@seisman
Copy link
Member

seisman commented Jun 18, 2025

for me it is somehow clear when clicking on the video images that I get redirected to YT and otherwise I just have get the image in larger dimension with the possibility seeing the content with more details, especially the posters.

I have the same feeling. When seeing a screenshot of a video recording, I would expect to be able to be redirected to the video when clicking the screenshot.

@michaelgrund
Copy link
Member Author

for me it is somehow clear when clicking on the video images that I get redirected to YT and otherwise I just have get the image in larger dimension with the possibility seeing the content with more details, especially the posters.

I have the same feeling. When seeing a screenshot of a video recording, I would expect to be able to be redirected to the video when clicking the screenshot.

That means we go with the links shown as text or remove them again?

@michaelgrund michaelgrund linked an issue Jun 18, 2025 that may be closed by this pull request
@seisman
Copy link
Member

seisman commented Jun 18, 2025

Maybe you can apply YF's suggestions and see how they look.

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman merged commit a37a012 into main Jun 18, 2025
10 of 11 checks passed
@seisman seisman deleted the add-links-yt branch June 18, 2025 12:16
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add youtube links in overview page?
3 participants