-
Notifications
You must be signed in to change notification settings - Fork 229
Add youtube links on landing and overview pages #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Addresses: #3975
Looks good. Could you please also update other links? |
Done! Just wanted to check if the syntax is working as expected before adding all links. If I remember correctly, unfortunately there's no recording from @yvonnefroehlich's recent AGU talk, isn't it? |
Unfortunaetly no 🙁. The AGU talks were available on the meeting plattform only for registered meeting attendees (and AGU members) to view through 7 March 2025. |
Also update the link at https://github.com/GenericMappingTools/pygmt/blob/main/README.md#why-pygmt? |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@yvonnefroehlich What do you think about changes in this PR? |
I personally have no strong opinion on showing also the URL to the YT videos as text. However, for me it is somehow clear when clicking on the video images that I get redirected to YT and otherwise I just have get the image in larger dimension with the possibility seeing the content with more details, especially the posters. |
[external PyGMT examples](https://www.pygmt.org/latest/external_resources.html)! | ||
|
||
 | ||
[](https://www.youtube.com/watch?v=4iPnITXrxVU) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check if the README on PyPI still looks nice with this change merged. I remember that there was an issue sometime ago and the image was not displayed correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect no issues since it's only a link embedded within another link.
I have the same feeling. When seeing a screenshot of a video recording, I would expect to be able to be redirected to the video when clicking the screenshot. |
That means we go with the links shown as text or remove them again? |
Maybe you can apply YF's suggestions and see how they look. |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Addresses: #3975
Preview: https://pygmt-dev--3977.org.readthedocs.build/en/3977/overview.html