Fix the bug when passing a sequence that contains True to a parameter #3982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
bug
seisman
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the bug when passing a sequence containing True to a parameter by modifying the argument list construction in pygmt.
- Adds a check inside the iterable processing to handle True values correctly.
- Updates the behavior in build_arg_list to distinguish between a bare True and other iterable elements.
Comments suppressed due to low confidence (1)
pygmt/helpers/utils.py:570
- [nitpick] Consider adding an inline comment to explain why the comprehension conditionally checks for True values within the iterable, for future maintainers.
gmt_args.extend(
weiji14
approved these changes
Jun 23, 2025
| Test for https://github.com/GenericMappingTools/pygmt/issues/3981. | ||
| """ | ||
| fig = Figure() | ||
| fig.basemap(region=[0, 10, 0, 10], projection="X10c", frame=[True, "WSen"]) |
There was a problem hiding this comment.
This translates to gmt basemap -R0/10/0/10 -JX10c -B -BWSen -pdf temp in GMT, which seems a little weird, but I see the output is different from gmt basemap -R0/10/0/10 -JX10c -BWSen -pdf temp, so ok I guess.
|
DVC test failed because they're not shipping binaries anymore? See bug report at iterative/setup-dvc#69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3981 for the bug report. Syntax like
frame=[True, "+tThe Caribbean Sea"]is not intuitive but is still valid. This PR fixes the issue by checking if a sequence contains True.Other values like
False/Noneare not checked, since they make no sense, e.g.,frame=[False, "+tThe Caribbean Sea"]Closes #3981.