Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Commit f84a3fd

Browse files
committed
Merge tag '2.29.1' into geotrek_UX_dev_mid_2018
2 parents 163c373 + be0b8e7 commit f84a3fd

File tree

7 files changed

+17
-8
lines changed

7 files changed

+17
-8
lines changed

CHANGES.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
1+
2.29.1-ux / 2020-10-20
2+
===================
3+
4+
**Bug fixes**
5+
6+
* Fix no pictogram trek's label should keep old icon
7+
8+
19
2.29.0-ux / 2020-10-20
210
======================
311

412
**Enhancements**
513

6-
* Add trek's label categories filtering
14+
* Add trek's label categories filtering (is park centered)
715
* Use trek's label warning
16+
**Warning:** these features are only available for Geotrek-admin >= 2.38.5
817

918

1019
2.28.2-ux / 2020-10-16

npm-shrinkwrap.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "geotrekrando",
3-
"version": "2.29.0-ux",
3+
"version": "2.29.1-ux",
44
"description": "Geotrek rando public portal of Geotrek",
55
"author": "Makina Corpus",
66
"main": "src/app/app.js",

src/app/categories/services.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function categoriesService(globalSettings, $q, treksService, contentsService, ev
7676
labels: {
7777
type: 'checkbox',
7878
values: aTrek.properties.labels ? angular.copy(aTrek.properties.labels) : []
79-
},
79+
}
8080
};
8181

8282
currentCategory.duration.values = _.map(_.sortBy(currentCategory.duration.values, 'id'));

src/app/detail/templates/detail-content.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ <h3>
8181
<div ng-repeat="label in result.properties.labels"
8282
class="detail-content-notice labels" ng-if="label">
8383
<span class="notice-symbol">
84-
<ng-include ng-if="label.pictogram | isSVG" src="label.pictogram"></ng-include>
85-
<img ng-if="!(label.pictogram | isSVG)" ng-src="{{label.pictogram}}" ng-alt="{{label.name}}">
84+
<ng-include ng-if="label.pictogram && label.pictogram | isSVG" src="label.pictogram"></ng-include>
85+
<img ng-if="label.pictogram && !(label.pictogram | isSVG)" ng-src="{{label.pictogram}}" ng-alt="{{label.name}}">
8686
<i ng-if="!label.pictogram" class="notice-symbol fa fa-info-circle"></i>
8787
</span>
8888

tests/dataset/api/es/treks.geojson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1916,4 +1916,4 @@
19161916
}
19171917
}
19181918
]
1919-
}
1919+
}

tests/dataset/api/fr/treks.geojson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3422,4 +3422,4 @@
34223422
}
34233423
}
34243424
]
3425-
}
3425+
}

0 commit comments

Comments
 (0)