Ensure MessageComposer respects the send- capabilities
#5973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes capability checks for the Message Composer and ensures correct handling of send-message vs send-reply based on context (channel vs thread), while tightening audio recording availability to actual send permissions.
- Introduces public canSendMessage and canUploadFile helpers and replaces scattered checks with these centralized functions.
- Ensures audio recording controls are hidden when the user cannot send (message or reply).
- Updates guides and UI components to use the new helpers.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stream-chat-android-ui-guides/.../MessagesActivity.kt | Replaces direct capability checks with canSendMessage/canUploadFile helpers in the sample activity. |
| stream-chat-android-ui-components/.../DefaultMessageComposerTrailingContent.kt | Switches to helpers and simplifies trailing content logic; removes unused utility method. |
| stream-chat-android-ui-components/.../DefaultMessageComposerLeadingContent.kt | Uses capability helpers to gate leading content behavior. |
| stream-chat-android-ui-components/.../DefaultMessageComposerCenterContent.kt | Uses canSendMessage to toggle input enabled state. |
| stream-chat-android-ui-common/.../MessageComposerCapabilitiesTest.kt | Adds parameterized tests for canSendMessage and canUploadFile. |
| stream-chat-android-ui-common/.../MessageComposerCapabilities.kt | Adds public helpers canSendMessage and canUploadFile with documentation. |
| stream-chat-android-ui-common/api/...ui-common.api | Updates public API surface to include new helper functions. |
| stream-chat-android-docs/.../AddingCustomAttachments.kt | Updates Kotlin docs to use new capability helpers. |
| stream-chat-android-docs/.../AddingCustomAttachments.java | Updates Java docs to use new capability helpers via static import. |
| stream-chat-android-compose/.../MessageComposer.kt | Adopts helpers; updates trailing and label behavior; records require send capability. |
| stream-chat-android-compose/.../MessageInput.kt | Uses canSendMessage helper for enabling input. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/MessageComposer.kt
Show resolved
Hide resolved
...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/MessageComposer.kt
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently the message composer only considered the
send-messagecapability, ignoring thesend-replyone. With this PR, we ensure the proper capability is checked, depending on whether the composer is used in a channel or in a thread.Docs PR: https://github.com/GetStream/docs-content/pull/686
🛠 Implementation details
send-messagecapability when in channelrend-replycapability when in threadMessageComposerCapabilities, which expose thecanSendMessageandcanUploadFile. Note: They are exposed as public, because I think they would be useful to provide to integrators developing custom composers.🎨 UI Changes
send-message-reply-before.mp4
send-message-reply-after.mp4
send-message-before.mp4
send-message-after.mp4
send-reply-before.mp4
send-reply-after.mp4
none-before.mp4
none-after.mp4
🧪 Testing
send-message, disable theCreateMessagepermission on dashboardCreateMessageandCreateReplypermissions on dashboardsend-reply, disableThreads & Replieson dashboard