[V5] Use Swift 6 with complete concurrency checking #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🤞 Ready for QA
🪧 Demo App
Public Interface public class CommandsHandler: CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public struct PaddingsConfig
+ public struct PaddingsConfig: Sendable
- public struct ConfirmationPopup
+ public struct ConfirmationPopup: Sendable
- public struct AddedAsset: Identifiable, Equatable
+ public struct AddedAsset: Identifiable, Equatable, Sendable
- open class ChatThreadListViewModel: ObservableObject, ChatThreadListControllerDelegate, EventsControllerDelegate
+ @MainActor open class ChatThreadListViewModel: ObservableObject, ChatThreadListControllerDelegate, EventsControllerDelegate
- public struct ChannelListSearchType: Equatable
+ public struct ChannelListSearchType: Equatable, Sendable
- public static var channels
+ public static let channels
- public static var messages
+ public static let messages
- public enum StreamChatErrorCode: Int
+ public enum StreamChatErrorCode: Int, Sendable
- public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDelegate
+ @MainActor public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDelegate
- public func leaveConversationTapped(completion: @escaping () -> Void)
+ public func leaveConversationTapped(completion: @escaping @MainActor() -> Void)
- open class MoreChannelActionsViewModel: ObservableObject
+ @MainActor open class MoreChannelActionsViewModel: ObservableObject
- public struct CustomAttachment: Identifiable, Equatable
+ public struct CustomAttachment: Identifiable, Equatable, Sendable
- public class PinnedMessagesViewModel: ObservableObject
+ @MainActor public class PinnedMessagesViewModel: ObservableObject
- public struct InjectedChannelInfo
+ public struct InjectedChannelInfo: Sendable
- open class MessageActionsViewModel: ObservableObject
+ @MainActor open class MessageActionsViewModel: ObservableObject
extension CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
public class Appearance
- public static var localizationProvider: (_ key: String, _ table: String) -> String
+ nonisolated public static var localizationProvider: @Sendable(_ key: String, _ table: String) -> String
- public struct PollsEntryConfig
+ public struct PollsEntryConfig: Sendable
public struct ComposerConfig
- public static var defaultAttachmentPayloadConverter: (ChatMessage) -> [AnyAttachmentPayload]
+ nonisolated public static var defaultAttachmentPayloadConverter: (ChatMessage) -> [AnyAttachmentPayload]
- public struct MessageActionInfo
+ public struct MessageActionInfo: Sendable
public class Utils
- public lazy var audioSessionFeedbackGenerator: AudioSessionFeedbackGenerator
+ @MainActor public lazy var audioSessionFeedbackGenerator: AudioSessionFeedbackGenerator
public class UnmuteCommandHandler: TwoStepMentionCommand
- override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public class PollAttachmentViewModel: ObservableObject, PollControllerDelegate
+ @MainActor public class PollAttachmentViewModel: ObservableObject, PollControllerDelegate
- open class ChannelHeaderLoader: ObservableObject
+ @MainActor open class ChannelHeaderLoader: ObservableObject
- public init()
+ nonisolated public init()
open class TwoStepMentionCommand: CommandHandler
- open func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ open func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
extension ChannelAction
- public static func defaultActions(for channel: ChatChannel,chatClient: ChatClient,onDismiss: @escaping () -> Void,onError: @escaping (Error) -> Void)-> [ChannelAction]
+ @MainActor public static func defaultActions(for channel: ChatChannel,chatClient: ChatClient,onDismiss: @escaping () -> Void,onError: @escaping (Error) -> Void)-> [ChannelAction]
- public struct ChannelAction: Identifiable
+ public struct ChannelAction: Identifiable, @unchecked Sendable
- public var navigationDestination: AnyView?
+ nonisolated public var navigationDestination: AnyView?
- public class ChannelAvatarsMerger: ChannelAvatarsMerging
+ public final class ChannelAvatarsMerger: ChannelAvatarsMerging
- open class MessageViewModel: ObservableObject
+ @MainActor open class MessageViewModel: ObservableObject
- public struct ChannelItemMutedLayoutStyle: Hashable
+ public struct ChannelItemMutedLayoutStyle: Hashable, Sendable
- public static var `default`: ChannelItemMutedLayoutStyle
+ public static let `default`: ChannelItemMutedLayoutStyle
- public static var topRightCorner: ChannelItemMutedLayoutStyle
+ public static let topRightCorner: ChannelItemMutedLayoutStyle
- public static var afterChannelName: ChannelItemMutedLayoutStyle
+ public static let afterChannelName: ChannelItemMutedLayoutStyle
- public protocol ChannelAvatarsMerging
+ public protocol ChannelAvatarsMerging: Sendable
- open class ReactionsOverlayViewModel: ObservableObject, ChatMessageControllerDelegate
+ @MainActor open class ReactionsOverlayViewModel: ObservableObject, ChatMessageControllerDelegate
- public struct PollsConfig
+ public struct PollsConfig: Sendable
public class MuteCommandHandler: TwoStepMentionCommand
- override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
open class NukeImageLoader: ImageLoading
- open func loadImage(using urlRequest: URLRequest,cachingKey: String?,completion: @escaping ((Result<UIImage, Error>) -> Void))
+ open func loadImage(using urlRequest: URLRequest,cachingKey: String?,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
- open func loadImages(from urls: [URL],placeholders: [UIImage],loadThumbnails: Bool,thumbnailSize: CGSize,imageCDN: ImageCDN,completion: @escaping (([UIImage]) -> Void))
+ open func loadImages(from urls: [URL],placeholders: [UIImage],loadThumbnails: Bool,thumbnailSize: CGSize,imageCDN: ImageCDN,completion: @escaping @MainActor @Sendable([UIImage]) -> Void)
- open func loadImage(url: URL?,imageCDN: ImageCDN,resize: Bool = true,preferredSize: CGSize? = nil,completion: @escaping ((Result<UIImage, Error>) -> Void))
+ open func loadImage(url: URL?,imageCDN: ImageCDN,resize: Bool = true,preferredSize: CGSize? = nil,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
- public protocol CommandHandler
+ @MainActor public protocol CommandHandler
- public struct AudioRecordingInfo: Equatable
+ public struct AudioRecordingInfo: Equatable, Sendable
- open class MessageComposerViewModel: ObservableObject
+ @MainActor open class MessageComposerViewModel: ObservableObject
- open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping () -> Void)
+ open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping @MainActor() -> Void)
- open class ChatChannelListViewModel: ObservableObject, ChatChannelListControllerDelegate, ChatMessageSearchControllerDelegate
+ @MainActor open class ChatChannelListViewModel: ObservableObject, ChatChannelListControllerDelegate, ChatMessageSearchControllerDelegate
- public enum AssetType
+ public enum AssetType: Sendable
- open class ChatChannelViewModel: ObservableObject, MessagesDataSource
+ @MainActor open class ChatChannelViewModel: ObservableObject, MessagesDataSource
public final class DefaultVideoPreviewLoader: VideoPreviewLoader
- public func loadPreviewForVideo(at url: URL,completion: @escaping (Result<UIImage, Error>) -> Void)
+ public func loadPreviewForVideo(at url: URL,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
public struct AppearanceKey: EnvironmentKey
- public static let defaultValue: Appearance
+ public static var defaultValue: Appearance
public struct StreamChatError: Error
- public let additionalInfo: [String: Any]?
+ public nonisolated let additionalInfo: [String: Any]?
open class StreamImageCDN: ImageCDN
- public static var streamCDNURL
+ public static let streamCDNURL
open class WaveformView: UIView
- public struct Content: Equatable
+ public struct Content: Equatable, Sendable
- public struct ChannelSelectionInfo: Identifiable
+ public struct ChannelSelectionInfo: Identifiable, Sendable
- public protocol AudioSessionFeedbackGenerator
+ @MainActor public protocol AudioSessionFeedbackGenerator
extension DateFormatter
- public static var messageListDateOverlay: DateFormatter
+ @MainActor public static var messageListDateOverlay: DateFormatter
- public struct TypingSuggestion
+ public struct TypingSuggestion: Sendable
- public class ViewModelsFactory
+ @MainActor public class ViewModelsFactory
- public struct AddedVoiceRecording: Identifiable, Equatable
+ public struct AddedVoiceRecording: Identifiable, Equatable, Sendable
public class InstantCommandsHandler: CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public protocol ViewFactory: AnyObject
+ @MainActor public protocol ViewFactory: AnyObject |
Generated by 🚫 Danger |
Public Interface open class WaveformView: UIView
- public struct Content: Equatable
+ public struct Content: Equatable, Sendable
- public struct ChannelAction: Identifiable
+ public struct ChannelAction: Identifiable, @unchecked Sendable
- public var navigationDestination: AnyView?
+ nonisolated public var navigationDestination: AnyView?
- public class PinnedMessagesViewModel: ObservableObject
+ @MainActor public class PinnedMessagesViewModel: ObservableObject
- public protocol AudioSessionFeedbackGenerator
+ @MainActor public protocol AudioSessionFeedbackGenerator
- public class ViewModelsFactory
+ @MainActor public class ViewModelsFactory
- open class MessageViewModel: ObservableObject
+ @MainActor open class MessageViewModel: ObservableObject
- public class ChannelAvatarsMerger: ChannelAvatarsMerging
+ public final class ChannelAvatarsMerger: ChannelAvatarsMerging
- public protocol ViewFactory: AnyObject
+ @MainActor public protocol ViewFactory: AnyObject
- public struct MessageActionInfo
+ public struct MessageActionInfo: Sendable
public final class DefaultVideoPreviewLoader: VideoPreviewLoader
- public func loadPreviewForVideo(at url: URL,completion: @escaping (Result<UIImage, Error>) -> Void)
+ public func loadPreviewForVideo(at url: URL,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
- open class ChatChannelListViewModel: ObservableObject, ChatChannelListControllerDelegate, ChatMessageSearchControllerDelegate
+ @MainActor open class ChatChannelListViewModel: ObservableObject, ChatChannelListControllerDelegate, ChatMessageSearchControllerDelegate
- public struct PaddingsConfig
+ public struct PaddingsConfig: Sendable
public class Utils
- public lazy var audioSessionFeedbackGenerator: AudioSessionFeedbackGenerator
+ @MainActor public lazy var audioSessionFeedbackGenerator: AudioSessionFeedbackGenerator
- public struct ConfirmationPopup
+ public struct ConfirmationPopup: Sendable
- public struct AddedAsset: Identifiable, Equatable
+ public struct AddedAsset: Identifiable, Equatable, Sendable
- public struct PollsConfig
+ public struct PollsConfig: Sendable
open class StreamImageCDN: ImageCDN
- public static var streamCDNURL
+ public static let streamCDNURL
- public enum AssetType
+ public enum AssetType: Sendable
- public struct InjectedChannelInfo
+ public struct InjectedChannelInfo: Sendable
- public struct ChannelItemMutedLayoutStyle: Hashable
+ public struct ChannelItemMutedLayoutStyle: Hashable, Sendable
- public static var `default`: ChannelItemMutedLayoutStyle
+ public static let `default`: ChannelItemMutedLayoutStyle
- public static var topRightCorner: ChannelItemMutedLayoutStyle
+ public static let topRightCorner: ChannelItemMutedLayoutStyle
- public static var afterChannelName: ChannelItemMutedLayoutStyle
+ public static let afterChannelName: ChannelItemMutedLayoutStyle
public struct ComposerConfig
- public static var defaultAttachmentPayloadConverter: (ChatMessage) -> [AnyAttachmentPayload]
+ nonisolated public static var defaultAttachmentPayloadConverter: (ChatMessage) -> [AnyAttachmentPayload]
public class Appearance
- public static var localizationProvider: (_ key: String, _ table: String) -> String
+ nonisolated public static var localizationProvider: @Sendable(_ key: String, _ table: String) -> String
- public enum StreamChatErrorCode: Int
+ public enum StreamChatErrorCode: Int, Sendable
- public struct ChannelSelectionInfo: Identifiable
+ public struct ChannelSelectionInfo: Identifiable, Sendable
public class InstantCommandsHandler: CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public protocol CommandHandler
+ @MainActor public protocol CommandHandler
- open class ReactionsOverlayViewModel: ObservableObject, ChatMessageControllerDelegate
+ @MainActor open class ReactionsOverlayViewModel: ObservableObject, ChatMessageControllerDelegate
- open class ChannelHeaderLoader: ObservableObject
+ @MainActor open class ChannelHeaderLoader: ObservableObject
- public init()
+ nonisolated public init()
- public struct TypingSuggestion
+ public struct TypingSuggestion: Sendable
- open class MoreChannelActionsViewModel: ObservableObject
+ @MainActor open class MoreChannelActionsViewModel: ObservableObject
- open class ChatThreadListViewModel: ObservableObject, ChatThreadListControllerDelegate, EventsControllerDelegate
+ @MainActor open class ChatThreadListViewModel: ObservableObject, ChatThreadListControllerDelegate, EventsControllerDelegate
open class TwoStepMentionCommand: CommandHandler
- open func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ open func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- open class MessageActionsViewModel: ObservableObject
+ @MainActor open class MessageActionsViewModel: ObservableObject
public struct StreamChatError: Error
- public let additionalInfo: [String: Any]?
+ public nonisolated let additionalInfo: [String: Any]?
- open class MessageComposerViewModel: ObservableObject
+ @MainActor open class MessageComposerViewModel: ObservableObject
- open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping () -> Void)
+ open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping @MainActor() -> Void)
- public protocol ChannelAvatarsMerging
+ public protocol ChannelAvatarsMerging: Sendable
open class NukeImageLoader: ImageLoading
- open func loadImage(using urlRequest: URLRequest,cachingKey: String?,completion: @escaping ((Result<UIImage, Error>) -> Void))
+ open func loadImage(using urlRequest: URLRequest,cachingKey: String?,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
- open func loadImages(from urls: [URL],placeholders: [UIImage],loadThumbnails: Bool,thumbnailSize: CGSize,imageCDN: ImageCDN,completion: @escaping (([UIImage]) -> Void))
+ open func loadImages(from urls: [URL],placeholders: [UIImage],loadThumbnails: Bool,thumbnailSize: CGSize,imageCDN: ImageCDN,completion: @escaping @MainActor @Sendable([UIImage]) -> Void)
- open func loadImage(url: URL?,imageCDN: ImageCDN,resize: Bool = true,preferredSize: CGSize? = nil,completion: @escaping ((Result<UIImage, Error>) -> Void))
+ open func loadImage(url: URL?,imageCDN: ImageCDN,resize: Bool = true,preferredSize: CGSize? = nil,completion: @escaping @MainActor @Sendable(Result<UIImage, Error>) -> Void)
- public struct ChannelListSearchType: Equatable
+ public struct ChannelListSearchType: Equatable, Sendable
- public static var channels
+ public static let channels
- public static var messages
+ public static let messages
extension CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public struct PollsEntryConfig
+ public struct PollsEntryConfig: Sendable
extension ChannelAction
- public static func defaultActions(for channel: ChatChannel,chatClient: ChatClient,onDismiss: @escaping () -> Void,onError: @escaping (Error) -> Void)-> [ChannelAction]
+ @MainActor public static func defaultActions(for channel: ChatChannel,chatClient: ChatClient,onDismiss: @escaping () -> Void,onError: @escaping (Error) -> Void)-> [ChannelAction]
public class UnmuteCommandHandler: TwoStepMentionCommand
- override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
public class CommandsHandler: CommandHandler
- public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
- public struct CustomAttachment: Identifiable, Equatable
+ public struct CustomAttachment: Identifiable, Equatable, Sendable
- public struct AudioRecordingInfo: Equatable
+ public struct AudioRecordingInfo: Equatable, Sendable
public class MuteCommandHandler: TwoStepMentionCommand
- override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping (Error?) -> Void)
+ override public func executeOnMessageSent(composerCommand: ComposerCommand,completion: @escaping @Sendable(Error?) -> Void)
extension DateFormatter
- public static var messageListDateOverlay: DateFormatter
+ @MainActor public static var messageListDateOverlay: DateFormatter
- public struct AddedVoiceRecording: Identifiable, Equatable
+ public struct AddedVoiceRecording: Identifiable, Equatable, Sendable
public struct AppearanceKey: EnvironmentKey
- public static let defaultValue: Appearance
+ public static var defaultValue: Appearance
- public class PollAttachmentViewModel: ObservableObject, PollControllerDelegate
+ @MainActor public class PollAttachmentViewModel: ObservableObject, PollControllerDelegate
- open class ChatChannelViewModel: ObservableObject, MessagesDataSource
+ @MainActor open class ChatChannelViewModel: ObservableObject, MessagesDataSource
- public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDelegate
+ @MainActor public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDelegate
- public func leaveConversationTapped(completion: @escaping () -> Void)
+ public func leaveConversationTapped(completion: @escaping @MainActor() -> Void) |
laevandus
commented
Aug 1, 2025
| @@ -43,14 +43,10 @@ only_rules: | |||
| - trailing_comma | |||
| - trailing_newline | |||
| - trailing_semicolon | |||
| - trailing_whitespace | |||
There was a problem hiding this comment.
This was breaking markdown tests which only happened in this PR because I did a change in MessageView_Test.swift which then led linter to lint the whole file and apply fixes. Some tests need soft linebreak which is (double space)
SDK Size
|
laevandus
commented
Aug 4, 2025
| @@ -1,6 +1,6 @@ | |||
| // The MIT License (MIT) | |||
There was a problem hiding this comment.
Do not review anything under StreamNuke, skip it
There was a problem hiding this comment.
Maybe we should consider removing it? We don't have gifs from here, and we might consider using AsyncImage wrapper?
There was a problem hiding this comment.
Not in the scope of this PR though
There was a problem hiding this comment.
If there is some time to do it in v5, we should. I'll add a ticket for that to the v5 list.
| token: token, | ||
| cid: cid | ||
| ) | ||
| Task { @MainActor in |
There was a problem hiding this comment.
We should have some consistency in how we run things on the main thread. On the other PR this was done with an abstraction.
There was a problem hiding this comment.
Since this piece is not part of the SDK and part of the demo app, I did not want to duplicate here. So demo app uses Task, SDK uses that abstraction (mostly)
| @@ -19,7 +18,9 @@ class ReactionsIconProvider { | |||
|
|
|||
| static func color(for reaction: MessageReactionType, userReactionIDs: Set<MessageReactionType>) -> Color? { | |||
| let containsUserReaction = userReactionIDs.contains(reaction) | |||
| let color = containsUserReaction ? colors.reactionCurrentUserColor : colors.reactionOtherUserColor | |||
| let color = containsUserReaction ? | |||
| InjectedValues[\.colors].reactionCurrentUserColor : | |||
There was a problem hiding this comment.
We should probably update the InjectedValues mechanism, using it like this kind of defeats its purpose.
There was a problem hiding this comment.
I see, the issue here is that colors is static var here and it has mutable properties so compiler is:
Static property 'colors' is not concurrency-safe because it is nonisolated global shared mutable state
On the second look, all of this should be MainActor. Let me see.
There was a problem hiding this comment.
Ah yeah, I'll revert and just make some things here @mainactor.
There was a problem hiding this comment.
Done, avoids this change
| public init() { | ||
| // Public init. | ||
| } | ||
|
|
||
| @Injected(\.utils) private var utils | ||
| @Injected(\.images) private var images | ||
| private var images: Images { InjectedValues[\.images] } |
There was a problem hiding this comment.
Same here, we should definitely do sth about this.
There was a problem hiding this comment.
The case here is that ChannelAvatarsMerger is called from background threads. @injected properties have mutable state and therefore must be concurrency safe. @injected is not, InjectedValues is internally nonisolated(unsafe) which makes the compiler happy. Alternative approach would be to pass Images and Utils in with the initialiser.
| @@ -36,7 +36,7 @@ open class ChannelHeaderLoader: ObservableObject { | |||
| private var loadedImages = [ChannelId: UIImage]() | |||
| private let didLoadImage = PassthroughSubject<ChannelId, Never>() | |||
|
|
|||
| public init() { | |||
| nonisolated public init() { | |||
There was a problem hiding this comment.
Utils creates this class in its init method, but Utils does not force MainActor. It is slightly bigger change because Utils is used in model objects (ChatChannel) what is Sendable. It is going to have bigger side-effects (all the callsites must ensure MainActor). Now the question is, should we try to make Utils @mainactor, maybe, but probably makes sense to have it in a separate ticket.
There was a problem hiding this comment.
If Utils is MainActor, then the high-level StreamChat must become MainActor as well.
There was a problem hiding this comment.
For now I took a shortcut here.
| @@ -1,6 +1,6 @@ | |||
| // The MIT License (MIT) | |||
There was a problem hiding this comment.
Maybe we should consider removing it? We don't have gifs from here, and we might consider using AsyncImage wrapper?
| @@ -1,6 +1,6 @@ | |||
| // The MIT License (MIT) | |||
There was a problem hiding this comment.
Not in the scope of this PR though
|
|
||
| import Foundation | ||
|
|
||
| enum StreamConcurrency { |
There was a problem hiding this comment.
We should move this to Core maybe?
There was a problem hiding this comment.
I'll add a note to consider it to the ticket we have about adding Stream Core to chat.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-736
🎯 Goal
Use Swift 6 with strict concurrency checking set to complete
📝 Summary
🛠 Implementation
Tried to make it as concise as possible, therefore in some cases there is
nonisolated(unsafe), because fixing them properly leads to huge refactoring (too large scope). In many cases this is actually all right.🧪 Manual Testing Notes
Needs full regression testing round.
☑️ Contributor Checklist
docs-contentrepo