Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Nov 7, 2025

Goal

AND-880

As the title says.

Note: I'm not running spotlessApply here to avoid bundling the migration with all the Spotless changes. I'll do it in a follow up (#26). What will change:

  • The headers will add an empty line -> This is how chat & video were configured, so I used their template to minimize the overall changes, since core & feeds' codebases are smaller
  • XML files now get the license header too

Implementation

Replace local Spotless configuration with the convention.

Testing

Run spotlessApply and verify that the files are updated accordingly.

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto requested a review from Copilot November 7, 2025 09:23
@gpunto gpunto added the pr:internal Internal changes / housekeeping label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from the Spotless plugin to a centralized Stream conventions plugin (version 0.3.0), consolidating code formatting, license management, and Maven publishing configuration. This refactoring removes local configuration in favor of convention-based setup.

Key changes:

  • Upgraded streamConventions from 0.2.0 to 0.3.0 and added stream-project plugin
  • Removed Spotless plugin and migrated formatting configuration to streamProject extension
  • Removed local license template files and license generation tasks

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gradle/libs.versions.toml Updated streamConventions version, added stream-project plugin, removed spotless plugin, fixed trailing space formatting
config/license/license.template Removed license template file (moved to conventions plugin)
config/license/generated/license-2025.txt Removed generated license file (moved to conventions plugin)
config/license/generated/license-2024.txt Removed generated license file (moved to conventions plugin)
build.gradle.kts Removed Spotless configuration, license generation tasks, and Maven publish configuration; added streamProject configuration block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@gpunto gpunto mentioned this pull request Nov 7, 2025
3 tasks
@gpunto gpunto marked this pull request as ready for review November 7, 2025 09:30
@gpunto
Copy link
Collaborator Author

gpunto commented Nov 7, 2025

@aleksandar-apostolov I'm not applying formatting here to avoid having all changes in the PR transitioning to the plugins. We can force merge this one and then merge the follow up: #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:internal Internal changes / housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants